From owner-freebsd-current Mon Mar 6 07:20:48 1995 Return-Path: current-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id HAA07659 for current-outgoing; Mon, 6 Mar 1995 07:20:48 -0800 Received: from Root.COM (implode.Root.COM [198.145.90.1]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id HAA07653 for ; Mon, 6 Mar 1995 07:20:44 -0800 Received: from corbin.Root.COM (corbin.Root.COM [198.145.90.18]) by Root.COM (8.6.8/8.6.5) with ESMTP id HAA03004; Mon, 6 Mar 1995 07:20:23 -0800 Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.9/8.6.5) with SMTP id HAA00590; Mon, 6 Mar 1995 07:20:22 -0800 Message-Id: <199503061520.HAA00590@corbin.Root.COM> X-Authentication-Warning: corbin.Root.COM: Host localhost didn't use HELO protocol To: starkhome!gene@sbstark.cs.sunysb.edu (Gene Stark) cc: current@FreeBSD.org, dyson@Root.COM Subject: Re: Page fault panics during make world in -current In-reply-to: Your message of "Mon, 06 Mar 95 08:46:58 EST." <199503061346.IAA03940@starkhome.cs.sunysb.edu> From: David Greenman Reply-To: davidg@Root.COM Date: Mon, 06 Mar 1995 07:20:22 -0800 Sender: current-owner@FreeBSD.org Precedence: bulk >In vfs_bio.c, line 758: > > for (toff = 0; toff < vp->v_mount->mnt_stat.f_iosize; toff += tinc) { > int mask; > >--> m = vm_page_lookup(obj, trunc_page(toff + off)); > if (!m) > return 0; > if (vm_page_is_valid(m, toff + off, tinc) == 0) > return 0; > } > >The VM object obj is not locked, contrary to the comment preceding >the definition of vm_page_lookup(). Potentially a problem? Object locking in uniprocessor systems is a NOP. If you look at the definition of vm_object_lock, you'll see that it is defined as "simple_lock". If you look at the definition of simple_lock, you'll see that it is nothing. The missing object locks are an oversight...but not a problem. -DG