From owner-svn-src-all@FreeBSD.ORG Sun Oct 27 10:11:16 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 97438ED4; Sun, 27 Oct 2013 10:11:16 +0000 (UTC) (envelope-from stefan@fafoe.narf.at) Received: from fep20.mx.upcmail.net (fep20.mx.upcmail.net [62.179.121.40]) by mx1.freebsd.org (Postfix) with ESMTP id 4A8FE2133; Sun, 27 Oct 2013 10:11:15 +0000 (UTC) Received: from edge01.upcmail.net ([192.168.13.236]) by viefep20-int.chello.at (InterMail vM.8.01.05.05 201-2260-151-110-20120111) with ESMTP id <20131027101108.BVV1967.viefep20-int.chello.at@edge01.upcmail.net>; Sun, 27 Oct 2013 11:11:08 +0100 Received: from mole.fafoe.narf.at ([80.109.55.137]) by edge01.upcmail.net with edge id iAB71m01f2xdvHc01AB7bl; Sun, 27 Oct 2013 11:11:08 +0100 X-SourceIP: 80.109.55.137 Received: by mole.fafoe.narf.at (Postfix, from userid 1001) id 86E616D47B; Sun, 27 Oct 2013 11:11:07 +0100 (CET) Date: Sun, 27 Oct 2013 11:11:07 +0100 From: Stefan Farfeleder To: Adrian Chadd Subject: Re: svn commit: r257133 - head/sys/dev/iwn Message-ID: <20131027101106.GA2843@mole.fafoe.narf.at> References: <201310251944.r9PJis6q004419@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201310251944.r9PJis6q004419@svn.freebsd.org> User-Agent: Mutt/1.5.22 (2013-10-16) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Oct 2013 10:11:16 -0000 On Fri, Oct 25, 2013 at 07:44:54PM +0000, Adrian Chadd wrote: > Author: adrian > Date: Fri Oct 25 19:44:53 2013 > New Revision: 257133 > URL: http://svnweb.freebsd.org/changeset/base/257133 > > Log: > Temporarily disable multi-rate retry (link quality) and eliminate rate > index lookups. > > * My recent(ish) change to iwn(4) and the net80211 rate control API to > support 11n rates broke the link quality table use. So, until I or > someone else decides to fix it, let's just disable it for now. > > * Teach iwn_tx_data_raw() to use the iwn_rate_to_plcp() function. > > * Eliminate two uses of the net80211 rate index lookup functions - they > are only for legacy rates and they're not needed here. > > This fixes some invalid looking rate control TX issues that showed up > on my 4965 but it doesn't fix the two TX hangs I've noticed. Those look > like DMA related issues. > > Tested: > > * 4965, STA mode > * 5100, STA mode Hi Adrian, this change completely broke iwn for me. It's a iwn0: mem 0xf1ffe000-0xf1ffffff irq 17 at device 0.0 on pci12 built-in device in a Dell Precision m4400. With this change, wpa_supplicant cannot associate any longer. In the logs I see every few seconds Oct 27 10:57:37 mole wpa_supplicant[2256]: wlan0: Trying to associate with xx:xx:xx:xx:xx:xx (SSID='xx' freq=2427 MHz) Oct 27 10:57:47 mole wpa_supplicant[2256]: wlan0: Authentication with xx:xx:xx:xx:xx:xx timed out. Oct 27 10:57:47 mole wpa_supplicant[2256]: wlan0: CTRL-EVENT-DISCONNECTED bssid=xx:xx:xx:xx:xx:xx reason=3 locally_generated=1 If I revert just this revision based on a r257155 checkout, it works again. Stefan