Date: Sat, 02 Apr 2016 15:51:23 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 208270] www/node: Fix build with libc++ 3.8.0 Message-ID: <bug-208270-13-UdLwbvXxSo@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-208270-13@https.bugs.freebsd.org/bugzilla/> References: <bug-208270-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D208270 --- Comment #2 from commit-hook@freebsd.org --- A commit references this bug: Author: dim Date: Sat Apr 2 15:51:19 UTC 2016 New revision: 412412 URL: https://svnweb.freebsd.org/changeset/ports/412412 Log: During the exp-run in bug 208158, it was found that www/node gives errors with libc++ 3.8.0 [1]: /usr/include/c++/v1/map:837:5: error: static_assert failed "Allocator::value_type must be same type as value_type" static_assert((is_same<typename allocator_type::value_type, value_type>::value), ^=20=20=20=20=20=20=20=20=20=20=20=20 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../deps/v8/src/compiler/js-type-feedback.h:41:21: note: in instantiation = of template class 'std::__1::map<unsigned int, v8::internal::TypeFeedbackId, std::__1::less<unsigned int>, v8::internal::zone_allocator<v8::internal::TypeFeedbackId> >' requested here TypeFeedbackIdMap type_feedback_id_map_; ^ This is because libc++ 3.8.0 has added these sanity checks for custom std::map allocators, which *must* be of the type std::pair<const Key, Value>. I fixed the few std::map instances in the node source by adding this to their allocator types. Approved by: linpct@gmail.com (maintainer) PR: 208270 MFH: 2016Q2 Changes: head/www/node/files/patch-deps_v8_src_compiler_instruction.h head/www/node/files/patch-deps_v8_src_compiler_js-type-feedback.h head/www/node/files/patch-deps_v8_src_zone-containers.h --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-208270-13-UdLwbvXxSo>