From owner-freebsd-hackers@FreeBSD.ORG  Tue Mar  9 09:35:27 2004
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 284D616A4CE
	for <freebsd-hackers@freebsd.org>;
	Tue,  9 Mar 2004 09:35:27 -0800 (PST)
Received: from purple.csi.cam.ac.uk (purple.csi.cam.ac.uk [131.111.8.4])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E54D443D1F
	for <freebsd-hackers@freebsd.org>;
	Tue,  9 Mar 2004 09:35:26 -0800 (PST)
	(envelope-from br260@hermes.cam.ac.uk)
Received: from maroon.csi.cam.ac.uk ([131.111.8.2])
	by purple.csi.cam.ac.uk with esmtp (Exim 4.20)
	id 1B0l8L-0007a7-Ao
	for freebsd-hackers@freebsd.org; Tue, 09 Mar 2004 17:35:13 +0000
Received: from prayer by maroon.csi.cam.ac.uk with local (Exim 4.24)
	id 1B0l8L-0004IO-9V
	for freebsd-hackers@freebsd.org; Tue, 09 Mar 2004 17:35:13 +0000
From: Bin Ren <br260@cam.ac.uk>
To: freebsd-hackers@freebsd.org
Date: 09 Mar 2004 17:35:13 +0000
X-Mailer: Prayer v1.0.9
X-Originating-IP: [131.111.242.109]
Mime-Version: 1.0
Content-Type: text/plain; format=flowed; charset=ISO-8859-1
Message-Id: <E1B0l8L-0004IO-9V.--077bfdda5c08a3dc1da12f192cb9c38ad6165f2b@maroon.csi.cam.ac.uk>
X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/
X-Cam-AntiVirus: No virus found
X-Cam-SpamDetails: Not scanned
Subject: ULE interactivity update
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Mar 2004 17:35:27 -0000

Hi,

in 'sys/kern/sched_ule.c', there is:

static void
sched_interact_update(struct ksegrp *kg)
{
        int sum;
                                                                                                                                                                                    
        sum = kg->kg_runtime + kg->kg_slptime;
        if (sum < SCHED_SLP_RUN_MAX)
                return;
        /*
         * If we have exceeded by more than 1/5th then the algorithm below
         * will not bring us back into range.  Dividing by two here forces
         * us into the range of [3/5 * SCHED_INTERACT_MAX, 
SCHED_INTERACT_MAX]
         */
        if (sum > (SCHED_INTERACT_MAX / 5) * 6) {
                kg->kg_runtime /= 2;
                kg->kg_slptime /= 2;
                return;
        }
        kg->kg_runtime = (kg->kg_runtime / 5) * 4;
        kg->kg_slptime = (kg->kg_slptime / 5) * 4;
}


Why here is 'SCHED_INTERACT_MAX' suddenly used instead of SCHED_SLP_RUN_MAX?
There is a huge difference between them, both in values and in meanings.

Thanks,
Bin