From owner-svn-src-stable-7@FreeBSD.ORG Mon Oct 27 20:43:31 2008 Return-Path: Delivered-To: svn-src-stable-7@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9F16C106567F; Mon, 27 Oct 2008 20:43:31 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 216C68FC24; Mon, 27 Oct 2008 20:43:31 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.3/8.14.3) with ESMTP id m9RKhCKS015014; Mon, 27 Oct 2008 16:43:13 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Ed Schouten Date: Mon, 27 Oct 2008 16:34:02 -0400 User-Agent: KMail/1.9.7 References: <200810262155.m9QLtJG5096815@svn.freebsd.org> <200810271422.06751.jhb@freebsd.org> <20081027194008.GO6808@hoeg.nl> In-Reply-To: <20081027194008.GO6808@hoeg.nl> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200810271634.03328.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Mon, 27 Oct 2008 16:43:13 -0400 (EDT) X-Virus-Scanned: ClamAV 0.93.1/8511/Mon Oct 27 14:23:52 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-7@freebsd.org Subject: Re: svn commit: r184300 - in stable/7/lib: libc/stdlib libutil X-BeenThere: svn-src-stable-7@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 7-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Oct 2008 20:43:31 -0000 On Monday 27 October 2008 03:40:08 pm Ed Schouten wrote: > * John Baldwin wrote: > > I would perhaps add a note that the duplicate revoke() in openpty() is only to > > support legacy libc's with broken unlockpt() routines. We could maybe remove > > the revoke()/ptsname() from openpty() on 8.x though as all 8.x machines > > should have a working unlockpt(). > > Good point, but I'd rather leave revoke() there for at least a couple of > months. If people just download the openpty() source from -CURRENT > through cvsweb and use it as an example for their own application, they > could create a potential security issue when they run the application on > RELENG_*. > > Shall we leave the revoke() call there for now, but remove it before we > ship 8.0-RELEASE? I would go ahead and axe it from 8 now since the safety net bits are in 6.x and 7.x already. I honestly wouldn't expect people to use openpty()'s implementation as the reference way to use posix_openpt() and friends. Rather, I imagine they would derive that from manpages online or other sources. -- John Baldwin