From owner-freebsd-rc@FreeBSD.ORG Wed Sep 8 13:43:27 2010 Return-Path: Delivered-To: rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4D8A110656B0; Wed, 8 Sep 2010 13:43:27 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 12EA68FC1E; Wed, 8 Sep 2010 13:43:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o88DYFDW095666; Wed, 8 Sep 2010 07:34:15 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 08 Sep 2010 07:34:28 -0600 (MDT) Message-Id: <20100908.073428.825430197519886678.imp@bsdimp.com> To: dim@freebsd.org From: "M. Warner Losh" In-Reply-To: <4C8736CA.9050200@FreeBSD.org> References: <20100907.180239.988891467257658938.imp@bsdimp.com> <4C8736CA.9050200@FreeBSD.org> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: rc@freebsd.org Subject: Re: Remove the only use of printf in /etc/rc.d X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Sep 2010 13:43:27 -0000 In message: <4C8736CA.9050200@FreeBSD.org> Dimitry Andric writes: : On 2010-09-08 02:02, M. Warner Losh wrote: : > Comments on the following patch? : > : > Warner : > : > Index: nsswitch : > =================================================================== : > --- nsswitch (revision 211943) : > +++ nsswitch (working copy) : > @@ -80,7 +80,7 @@ : > cache | *=*) : > ;; : > *) : > - printf "Warning: unrecognized source [%s]\n" $_s>&2 : > + echo "Warning: unrecognized source [$_s]">&2 : : Indeed, printf seems to be unnecessary here. It looks like it snuck : in, : when somebody converted from a bit of inline awk scripting to plain : sh: : : http://svn.freebsd.org/viewvc/base/head/etc/rc.d/nsswitch?view=diff&r1=156916&r2=156917 Yea, that's my read too... It is either extremely subtle, or an oops. Warner