From nobody Wed Jul 26 15:22:07 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4R9yLW0lVxz4pgj8; Wed, 26 Jul 2023 15:22:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4R9yLR6gqsz3xfw; Wed, 26 Jul 2023 15:22:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690384928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=33QClqmJT/mMyctyJ/9zw0p2s6qoG4C6r3syqdM2q7w=; b=xeGiCeWD2cZenfpJlfsyoSMvXxTD906XB/KA3fAtXb6+358cRI2aTk65Z22OlfTZmux9WV wv4tQf7B3e36al2WXPtqpNDFcYoKqWU40NNV0dSaHdS8b+t6hcYbaRxllQqfEsudxtVlm7 Je/0m3RGi52K3nIcl4XjRrC91iIzQGkamO3xR2XV1PAJJXixjpjxk5UUvMOnvQ0LCOfuS4 xRxT1QbIoJWi2jgTf1DGkKx85iqxjFn3BhWSMsxw5gDHZBCg6VUNik0qVpnWGZW2YyHpxR 0GKgaRxPyR/0YXskFn+nh+Q57nhtBDmlNtLYBko/BQFa6VDtPyzOxEg0HXoCqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690384928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=33QClqmJT/mMyctyJ/9zw0p2s6qoG4C6r3syqdM2q7w=; b=vDoUCbJsrq6die52XTTj09IGrbg4rUKR9QirHC0pTw+GSNMmDM7MRrAyt88PuLwAYhN985 2v9uRpRrDF3RyX49tMJCSqLRbs7WzF8q3iqQCfwCw76i7mexgdmkWeNxC0ws8cOTDuQWy9 RBVwug328ryHvi/rTZxjV+iY6xmsWCWsgRzX8bvbjUy6/2IBZyWoKCxW/4aG/LIQXu4M+1 nQKmV+7WlklwI5J6OEmojK87SZ89bH4VyUWGRhea0WgtHHoyVQOTrWUAkf88sPZLt/O8xs 1HymoYUQOBloDt5k9aAFO1orC1FTkSReaBzHHYoqbCJo5OlLmtd3zrbuCSht/g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1690384928; a=rsa-sha256; cv=none; b=slKndv+hCE2J+Km6wFqW0Vs/cNR0tdCqYAqGAAyAZl6CVmQcVXngzz5l8yVLWZGHj4Sv6O l+rxxG3O4nnVyYhH0cp7f8XgasL4gFZEcfQN6mNIwSVbaF5RqocmOuQpGkXWWgB6nTAdQv wFHcF74YDgICTFafoLyERAEdI3zw0JAxIg1T+l92WlPOIH5NKhQKF3hLFambjec+SRyynw BaGFqqKn4vP7CY6k+4QOOa2E+/ixhFqCDl6NIdnAfggak+unU/HsPoV0p9zXVwxdJBYIXP Ridfh0KSAHvS7kf/lCdkh8zu75bMauCaGG/1bNnOzchdi1hg8Cw7WjBeSCeb3w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4R9yLR4VJLznCH; Wed, 26 Jul 2023 15:22:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 36QFM7Ig017891; Wed, 26 Jul 2023 15:22:07 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 36QFM7pl017890; Wed, 26 Jul 2023 15:22:07 GMT (envelope-from git) Date: Wed, 26 Jul 2023 15:22:07 GMT Message-Id: <202307261522.36QFM7pl017890@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: dfe172484d0e - main - sigtd(): prefer non-stopped thread as a target for signal queue List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: dfe172484d0e1de0bb32bcab8775eb83e15031c0 Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=dfe172484d0e1de0bb32bcab8775eb83e15031c0 commit dfe172484d0e1de0bb32bcab8775eb83e15031c0 Author: Konstantin Belousov AuthorDate: 2023-07-21 09:41:39 +0000 Commit: Konstantin Belousov CommitDate: 2023-07-26 15:12:55 +0000 sigtd(): prefer non-stopped thread as a target for signal queue This should improve signal delivery latency and better expose the process state to the executing threads. Reviewed by: markj Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D41128 --- sys/kern/kern_sig.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sys/kern/kern_sig.c b/sys/kern/kern_sig.c index de42255017d8..5876e2e93920 100644 --- a/sys/kern/kern_sig.c +++ b/sys/kern/kern_sig.c @@ -2157,14 +2157,18 @@ sigtd(struct proc *p, int sig, bool fast_sigblock) if (curproc == p && !SIGISMEMBER(curthread->td_sigmask, sig) && (!fast_sigblock || curthread->td_sigblock_val == 0)) return (curthread); + + /* Find a non-stopped thread that does not mask the signal. */ signal_td = NULL; FOREACH_THREAD_IN_PROC(p, td) { if (!SIGISMEMBER(td->td_sigmask, sig) && (!fast_sigblock || - td != curthread || td->td_sigblock_val == 0)) { + td != curthread || td->td_sigblock_val == 0) && + (td->td_flags & TDF_BOUNDARY) == 0) { signal_td = td; break; } } + /* Select random (first) thread if no better match was found. */ if (signal_td == NULL) signal_td = FIRST_THREAD_IN_PROC(p); return (signal_td);