From owner-svn-src-all@freebsd.org Tue Apr 4 15:19:17 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BA966D2E931 for ; Tue, 4 Apr 2017 15:19:17 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lf0-f65.google.com (mail-lf0-f65.google.com [209.85.215.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 64ADDD0F for ; Tue, 4 Apr 2017 15:19:17 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mail-lf0-f65.google.com with SMTP id x137so15814794lff.1 for ; Tue, 04 Apr 2017 08:19:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=BFGjt5zfaTsnkArbqpgtcUqUj6VaCZnWN7rD/sNJJRs=; b=oMqoUziSqlDAIpMfQiKtdtYIVVQIJDtvxeuxymZVmFITuY3w9BRpYKJ6eBB7lb5myS HnQeJ2RTHEOJVV0GLdI4uUNmo8ns2hNHhIiNN3VlRGqyy/zpLQmQMJHfzmKWEzxMQ5Zz Zg3X/5qUhCttqo5UqY55cUZLUUPb2KYRuvKY8wGyWpEuHb9WF50qc0ReaQGnbbW6jtNQ o5G3x8Aylrfytsrl+2wB7pP29YpgfKf9JKIDibqIR1J1bv4fT/Z5EkGfbW4Pm8gjZ0s+ 31/p6An5yXS2yA3Yxk7T5EjrFqR5Q6Dm1noGfIIH842LjwoxqCoSZS9At1lvPHppH50M xing== X-Gm-Message-State: AFeK/H2Q43m/FHRO7CNdh7/9FooVfqf74qupEzmFkGnJC91245p7VS78JGhY2MyBoCwnIw== X-Received: by 10.25.80.1 with SMTP id e1mr2759811lfb.82.1491319154955; Tue, 04 Apr 2017 08:19:14 -0700 (PDT) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id 4sm3197400ljf.33.2017.04.04.08.19.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Apr 2017 08:19:14 -0700 (PDT) Subject: Re: svn commit: r316477 - head/usr.bin/grep To: Kyle Evans References: <201704032316.v33NGpbo037305@repo.freebsd.org> <4ceb1a18-3a72-c0e3-b2e2-f71d687cd153@freebsd.org> <9018c8db-2a89-c8b2-750b-fe11ac08333f@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Ed Maste From: Andrey Chernov Message-ID: Date: Tue, 4 Apr 2017 18:19:13 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 15:19:17 -0000 On 04.04.2017 16:41, Kyle Evans wrote: > Upon further review, newer versions of GNU grep(1) drop the explicit > '00' and add the \33[K dropped in this commit a few lines above the > mentioned one. In that case, we might as well revert those two lines and > consider this an improvement. I guess it depends on the overall outlook > of the tests, though -- should we introduce more tests that fail by > default as they go in, or adapt similar (not strictly buggy, but not > ideal) behavior to start with and then improve after we can grant > bsdgrep(1) replacement status? It seems new GNU grep takes right course, so I vote to make our thing like there and not as in its obsoleted version. \33[K clears from cursor to the rest of the line (with background color, in case terminal have "ut" termcap capability). Consider how multi-line pattern will look with it and without.