From owner-freebsd-current@FreeBSD.ORG Thu Oct 31 03:41:11 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 78D8494 for ; Thu, 31 Oct 2013 03:41:11 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-qe0-x233.google.com (mail-qe0-x233.google.com [IPv6:2607:f8b0:400d:c02::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 396902B92 for ; Thu, 31 Oct 2013 03:41:11 +0000 (UTC) Received: by mail-qe0-f51.google.com with SMTP id q19so1404749qeb.24 for ; Wed, 30 Oct 2013 20:41:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=iNEPkUOJ35IY8YyfjO2rXGCSMjlWgMKbNF4Vf0xSB7Y=; b=c6pTeN3hkOIk7uBwi7D+nDc9lK36xY2Aeodx+TcOAIIvJOaF7TbuWjhfHPXtcECnTO 0lIH3B8PVotCi8LUSM2MxvetpdK8t6jRpu10SVcpiT9T4NcmisWzjIQ2b1dBfu/vjbK3 A61PrwCklM2/vqrz68X3t/ynM1NPrsXNST8Oo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=iNEPkUOJ35IY8YyfjO2rXGCSMjlWgMKbNF4Vf0xSB7Y=; b=F8lJynT5VaeciZDMpQ1Vy4qetky18XD6RmiFDgBF9yC/FXJOqvDFiZTL3YsUJZiuM8 H3ToyUnRXO/MD28IYBQvtqcN99j9w1AfZaUxjV51xUZoQWnGyMBZOxn0nfkDXjnh+6mu vObqSH+ArEsFPdjlxUIozteoGdFGMycXmEuoIWPcZzaFWH204q19cEIauxhVDj5YwBvV Y4e36AZsJxM6L1fERRPa2QGK4Xgw4CmTMij5vpgCBEmvNj08WQ6cY5BQj418QNu7eMSI /iw8VAfdeoTr4QVhBTFoHqoWgncROJ3iIM1ZQxoOuy6pmB/Y9j0lHlHTGqbXc2HQwt/U PB9Q== X-Gm-Message-State: ALoCoQm+emZEKSsUm7hgi4oD3iIst54jXbaQeX0JWUzOBGZoWK93C8sju5gH1FA/+s9a5xq6zGnf X-Received: by 10.229.79.70 with SMTP id o6mr1244140qck.21.1383190870224; Wed, 30 Oct 2013 20:41:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.96.63.101 with HTTP; Wed, 30 Oct 2013 20:40:40 -0700 (PDT) In-Reply-To: <1383180558.1751.12.camel@localhost> References: <1383180558.1751.12.camel@localhost> From: Eitan Adler Date: Wed, 30 Oct 2013 23:40:40 -0400 Message-ID: Subject: Re: [PATCH] Adjust binutils to quiesce -Wstring-plus-int To: Sean Bruno Content-Type: text/plain; charset=UTF-8 Cc: "freebsd-current@freebsd.org" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Oct 2013 03:41:11 -0000 On Wed, Oct 30, 2013 at 8:49 PM, Sean Bruno wrote: > Spent some time doing string maths today. > > More or less, change the "static char intel_syntax" to an int and use it > as an array index instead of doing pointer math. > > Sean > > http://people.freebsd.org/~sbruno/binutils_opcodes.txt While the patch seems reasonable, I once again am confused about why we are fixing these warnings and not just disabling them for contributed code. -- Eitan Adler