From owner-cvs-all@FreeBSD.ORG Thu Nov 30 17:27:59 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CA9FA16A58D; Thu, 30 Nov 2006 17:27:59 +0000 (UTC) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (relay0.rambler.ru [81.19.66.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1645843DA7; Thu, 30 Nov 2006 17:26:30 +0000 (GMT) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (localhost [127.0.0.1]) by relay0.rambler.ru (Postfix) with ESMTP id 86FA969B8; Thu, 30 Nov 2006 20:26:32 +0300 (MSK) Received: from edoofus.park.rambler.ru (unknown [81.19.65.108]) by relay0.rambler.ru (Postfix) with ESMTP id 7DEB369B7; Thu, 30 Nov 2006 20:26:32 +0300 (MSK) Received: (from ru@localhost) by edoofus.park.rambler.ru (8.13.8/8.13.8) id kAUHQYNn011146; Thu, 30 Nov 2006 20:26:34 +0300 (MSK) (envelope-from ru) Date: Thu, 30 Nov 2006 20:26:34 +0300 From: Ruslan Ermilov To: Sam Leffler Message-ID: <20061130172634.GC75179@rambler-co.ru> References: <200611301502.kAUF22lU076210@repoman.freebsd.org> <456F0B71.3050604@errno.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9ADF8FXzFeE7X4jE" Content-Disposition: inline In-Reply-To: <456F0B71.3050604@errno.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-Virus-Scanned: No virus found Cc: cvs-src@FreeBSD.org, Gleb Smirnoff , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/net if.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2006 17:27:59 -0000 --9ADF8FXzFeE7X4jE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 30, 2006 at 08:48:49AM -0800, Sam Leffler wrote: > Gleb Smirnoff wrote: > > glebius 2006-11-30 15:02:01 UTC > >=20 > > FreeBSD src repository > >=20 > > Modified files: > > sys/net if.c=20 > > Log: > > The recent issues with em(4) interface has shown that the old 4.4BSD > > if_watchdog/if_timer interface doesn't fit modern SMP network > > stack design. > > =20 > > Device drivers that need watchdog to monitor their hardware should > > implement it theirselves. > > =20 > > Eventually the if_watchdog/if_timer API will be removed. For now, > > warn that driver uses it. > > =20 > > Reviewed by: scottl >=20 > Did I miss a headsup on this? Seems like something you should > coordinate with folks so people can convert drivers beforehand. I > understand the problem and I see this is just a printf but now we're > going to have people asking what's going on. >=20 Yeah, with only two drivers in the tree using a new approach (if I'm not mistaken based on what Gleb told me today) calling it "obsolete" was I think (ahem) a bit premature. However, calling it "dangerous" would be accurate and more threatening! That way, I hope Sam's concern will be addressed as well, as it IS dangerous, and there's no reason to hide the truth waiting for most drivers to be converted. BTW, is if_{watchdog|timer} also dangerous for !MPSAFE drivers? Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --9ADF8FXzFeE7X4jE Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFbxRKqRfpzJluFF4RAgQ2AKCLHupbeJni4TD2zRzKNxDPi/VfUQCdFZFM mddnjNnlWiNkfmO6y3HyuUQ= =1nZK -----END PGP SIGNATURE----- --9ADF8FXzFeE7X4jE--