From owner-freebsd-toolchain@FreeBSD.ORG Thu Apr 7 21:58:03 2011 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AD02A106566B; Thu, 7 Apr 2011 21:58:03 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-pv0-f182.google.com (mail-pv0-f182.google.com [74.125.83.182]) by mx1.freebsd.org (Postfix) with ESMTP id 734248FC16; Thu, 7 Apr 2011 21:58:03 +0000 (UTC) Received: by pvg11 with SMTP id 11so1326039pvg.13 for ; Thu, 07 Apr 2011 14:58:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=x2JWrkVPYGpTkqlkWFSmRT0BF8szLnlNnVZbl6uNpG8=; b=jeFR98Ys+gAr2rrZkgeuFQENs/YpOnEsPDUrFcksDkqRtAHSz/wtCDPpu69guAMDbp yZmRotAqvS1MGkxeU6vhcSBNv9pnccXqbdhLcJyuvHQnhQ+ABAscFI+Rr8HUp+tOZ1eH ajCE5CDbElRrCBO//jeOSd4SoHq3dLWWqKP6Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=L8nqe6ZXt8UDK8jncuTCmC56gjc38P7k5mPUifWY8D1mNeN6p0wcd4BohCYIFUkQHd tX8vRkZ5I8Fr94flaI6xPZg7uUazUAG1F3taoHkVsIQFRnVn8PECqT1EOVjfjjiTZ0Rh c4FDxwAKMuCqm28nZY5o5AJQYCTEXGdMoAUCI= MIME-Version: 1.0 Received: by 10.142.152.3 with SMTP id z3mr1063382wfd.398.1302213483013; Thu, 07 Apr 2011 14:58:03 -0700 (PDT) Received: by 10.68.42.3 with HTTP; Thu, 7 Apr 2011 14:58:02 -0700 (PDT) In-Reply-To: <20110407212225.GA17091@freebsd.org> References: <20110407185510.GA94830@freebsd.org> <20110407212225.GA17091@freebsd.org> Date: Thu, 7 Apr 2011 14:58:02 -0700 Message-ID: From: Garrett Cooper To: Alexander Best Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org, freebsd-toolchain@freebsd.org Subject: Re: [RFC] adding -Wmissing-include-dirs to CWARNFLAGS X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2011 21:58:03 -0000 On Thu, Apr 7, 2011 at 2:22 PM, Alexander Best wrote: > On Thu Apr =A07 11, Garrett Cooper wrote: >> On Thu, Apr 7, 2011 at 1:53 PM, Garrett Cooper wrot= e: >> > On Thu, Apr 7, 2011 at 11:55 AM, Alexander Best = wrote: >> >> hi there, >> >> >> >> i'd like to propose adding -Wmissing-include-dirs to CWARNFLAGS. this= will let >> >> tinderbox fail, if any new kernel code was committed with (a) broken = include >> >> dir(s). >> >> >> >> i ran a test via >> >> >> >> make toolchains >> >> make MAKE_JUST_KERNELS=3Dyes tinderbox >> >> >> >> and nothing seemed to go wrong with the extra warning enabled. i even= found a >> >> missing include dir, which should be fixed by the attached patch. >> >> >> >> opinions? >> >> >> >> so far i've only tested this with gcc. i think someone on #freebsd-cl= ang told >> >> me that -Wmissing-include-dirs is a noop for clang (for whatever reas= ons). >> > >> > =A0 =A0make -f /etc/src.conf -VMODULES_OVERRIDE and make -f /etc/src.c= onf >> > -VMODULES_OVERRIDE say... (tinderbox should also really ignore these >> > files, but it doesn't currently)? > > otaku% make -f /etc/src.conf -VMODULES_OVERRIDE > netgraph/netgraph netgraph/socket netgraph/bluetooth/bluetooth =A0netgrap= h/bluetooth/hci netgraph/bluetooth/l2cap netgraph/bluetooth/socket =A0netgr= aph/bluetooth/ubt tmpfs sound/sound sound/driver/hda usb/uhid =A0procfs pse= udofs linux linprocfs linsysfs lindev usb/quirk geom =A0opensolaris dtrace = cyclic nfsclient krpc nfs_common nfslock > otaku% make -f /etc/make.conf -VMODULES_OVERRIDE > netgraph/netgraph netgraph/socket netgraph/bluetooth/bluetooth =A0netgrap= h/bluetooth/hci netgraph/bluetooth/l2cap netgraph/bluetooth/socket =A0netgr= aph/bluetooth/ubt tmpfs sound/sound sound/driver/hda usb/uhid =A0procfs pse= udofs linux linprocfs linsysfs lindev usb/quirk geom =A0opensolaris dtrace = cyclic nfsclient krpc nfs_common nfslock > > ...however i checked and tinderbox *does* ignore src.conf and make.conf. = the > _.* log files show that modules were being build which are not returned b= y > the commands above. > > i think having this flag would be very useful, because it would force peo= ple to > make sure their include dirs are correct. > >> >> Sorry. Second invocation should have been make.conf, not src.conf. Ok then. I stand corrected for not having tested out my claim beforehand. Yes, I agree that adding this flag in the default set is a good idea. Thanks, -Garrett