From owner-freebsd-current@FreeBSD.ORG Fri Feb 27 00:07:21 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 113CE16A4CE; Fri, 27 Feb 2004 00:07:21 -0800 (PST) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 54E1A43D39; Fri, 27 Feb 2004 00:07:19 -0800 (PST) (envelope-from ru@ip.net.ua) Received: from heffalump.office.ipnet (heffalump.office.ipnet [10.71.1.80]) by tigra.ip.net.ua (8.12.10/8.12.9) with ESMTP id i1R89P7I057133 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 27 Feb 2004 10:09:26 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.office.ipnet (8.12.11/8.12.11) id i1R87Dvg094025; Fri, 27 Feb 2004 10:07:13 +0200 (EET) (envelope-from ru) Date: Fri, 27 Feb 2004 10:07:13 +0200 From: Ruslan Ermilov To: Brooks Davis Message-ID: <20040227080713.GC93889@ip.net.ua> References: <200402180859.59763.jhb@FreeBSD.org> <20040219112126.GB8950@ip.net.ua> <200402190930.53205.jhb@FreeBSD.org> <20040220085606.GA28677@ip.net.ua> <20040227012233.GA25598@Odin.AC.HMC.Edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lCAWRPmW1mITcIfM" Content-Disposition: inline In-Reply-To: <20040227012233.GA25598@Odin.AC.HMC.Edu> User-Agent: Mutt/1.5.6i X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: "Bjoern A. Zeeb" cc: current@FreeBSD.org cc: John Baldwin Subject: Re: pxeloader problem: BTX halted X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Feb 2004 08:07:21 -0000 --lCAWRPmW1mITcIfM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 26, 2004 at 05:22:33PM -0800, Brooks Davis wrote: [...] > This commit broke PXE booting: >=20 > ----- > ru 2004/02/09 06:11:58 PST >=20 > FreeBSD src repository >=20 > Modified files: > sys/boot/i386 Makefile.inc > sys/boot/i386/boot0 Makefile > sys/boot/i386/boot2 Makefile > sys/boot/i386/btx/btx Makefile > sys/boot/i386/btx/btxldr Makefile > sys/boot/i386/btx/lib Makefile > sys/boot/i386/cdboot Makefile > sys/boot/i386/kgzldr Makefile > sys/boot/i386/loader Makefile > sys/boot/i386/mbr Makefile > sys/boot/i386/pxeldr Makefile > Log: > - Factor out -nostdlib to an upper level Makefile.inc. > =20 > - Now that bsd.prog.mk deals with programs linked with -nostdlib > better, and has a notion of an "internal" program, use PROG > where possible. This has a good impact on the contents of > .depend files and causes programs to be linked with cc(1). >=20 > XXX: boot2 couldn't be converted as it's actually two programs. >=20 > Tested on: i386, amd64 > ----- >=20 > I verified this with a binary search using perforce syncing against a > local checkout of //depot/vendor/freebsd/src/. At 2004/02/09:06:15 > pxeldr works. At 2004/02/09:06:16 it dies. The only files that change > in this time frame are these files in sys/boot. >=20 > Specifically the problem is rev 1.73 of sys/boot/i386/loader/Makefile. A > tip of tree checkout with rev 1.73 removed PE boots. >=20 So, does backing it out solve your problem, if you downgrade only sys/boot/ to the date prior to this commit? I doubt it, because I've verified that my changes produce identical binaries. The only difference now is because vers.o and ../btx/lib/crt.o are linked into the loader.sym binary in a slightly different order. By making some insignificant changes to loader/Makefile I've been able to verify that I still get the identical binaries (for all of sys/boot/i386/) with my changes, after I saw your first complaint in this thread. Cheers, --=20 Ruslan Ermilov FreeBSD committer ru@FreeBSD.org --lCAWRPmW1mITcIfM Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAPvqxUkv4P6juNwoRAkXDAJ9YA+r2Wu7Oi8vs4nwVWEYE9vrefACffnCF co/fy8Iz6mPSxhh8JNnkeeA= =vj5g -----END PGP SIGNATURE----- --lCAWRPmW1mITcIfM--