From nobody Mon Jul 7 10:07:05 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bbKfL42Wxz61Jrr; Mon, 07 Jul 2025 10:07:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bbKfL0SYYz3f1x; Mon, 07 Jul 2025 10:07:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751882826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vcRmqS6jAgnWwBCczFn3fIigvxm8fIJXO0VOtAngi6c=; b=ksyvS2OkiDHrr0z1aRcEjt45I1yYnXLLmNfowEbxJQ5GH14mqwyhjaE6hZdMV5Amr894xA DiGX0MBoq4YCNuo4a5F6t63NVCZy5mPm4nidmWomw1IchTzVnK48e+KwBUsPWJ/II7UxXx f3ZYZPz8O5/eKXB8Glqy9D3D1QXgJuMT+5Kc5reACA7s5d9/a1UwtRnz63nfQbS53JjFM2 1Z2F9xzB9Brxs/ZJfTgNdJOhn1uOtc5t+mR0aApYvWY0OwvzKQ1WalTYKYOIc8/YBTkOcH aHu5qHwvev3ddSnXVWqqMMHSIUYH/3M0BYVWkTrkZYyVnWcIcvG7w+Zm7YwuVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751882826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vcRmqS6jAgnWwBCczFn3fIigvxm8fIJXO0VOtAngi6c=; b=JjEXcNccmDnYhxgdddrqZRCavO0ofdXoGpFh1SJkKPKchxSaRmn634l8Cq8cA/rVuw8aBN vl4mATcA6XeFU7eMg68b7qgwnvQXFOb+wTAwdePYklKpf6xCAzp/d238Bfumt4Mbj02EqM DH0hGRqcoWyk634hGCANgwy6W0jOz14TyAqqr5dbsyeH1K2LEF+ciSpGGmKtFM8psqkE/c YAuRlzxX366x6TsMeIZOUIEylIm7UO5V+H2gFiCxZz237VlmdaFwAykAfEnKQXZmikXkQS 4KWUhV5EGVgu1zoCqqQ0qAasCGLLd/4pv5Aouwv6LEgiEkam7cKmfVDBMKl4CQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751882826; a=rsa-sha256; cv=none; b=VjC8UMVaBgWl2w4jvZwOKdnCo+lGf04dmuUJJF2QFDNS7ljEQbY61B/T4rP4BJyPw6PSkH JI0s1wvwwdcuEW7N9a8Ch932QmI5mX3qPzZTm0PSra6d7f19xPJzfvkXyPDd3gpp+VOvGc DLLMqmkxuE1rYSSMSiXOYdWA9BP28l35x8SYWFXTtnp/IDmH6IJtDiuHfK8m1jHyVg5dxS hSi0sHsKJIELi/v6xUxmoSq0LwTFghqaLWuqm5jQ3+t8zjLf5RtgyWuNCZi7PcprultleL d6xJW7gjcmAeiNxGR7pUccUlyX2mNwadsoLtI5gboVVUxUlxuF1v1euifb/S+g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bbKfL04Y2zmvF; Mon, 07 Jul 2025 10:07:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 567A75ub053675; Mon, 7 Jul 2025 10:07:05 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 567A75TX053672; Mon, 7 Jul 2025 10:07:05 GMT (envelope-from git) Date: Mon, 7 Jul 2025 10:07:05 GMT Message-Id: <202507071007.567A75TX053672@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Zhenlei Huang Subject: git: efbaf14c5b68 - stable/14 - pfsync: Destroy buckets mutexes on clone destroying interface List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: efbaf14c5b681c8f1a04a47c7bf8740134fff098 Auto-Submitted: auto-generated The branch stable/14 has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=efbaf14c5b681c8f1a04a47c7bf8740134fff098 commit efbaf14c5b681c8f1a04a47c7bf8740134fff098 Author: Zhenlei Huang AuthorDate: 2025-06-28 15:46:51 +0000 Commit: Zhenlei Huang CommitDate: 2025-07-07 10:05:10 +0000 pfsync: Destroy buckets mutexes on clone destroying interface So that the associated data with them will be freed. Reviewed by: kp Fixes: 4fc65bcbe3fb pfsync: Performance improvement MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D51063 (cherry picked from commit 8213c07c20586a67bc7f7152bd7ff76c02cbc007) --- sys/netpfil/pf/if_pfsync.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/netpfil/pf/if_pfsync.c b/sys/netpfil/pf/if_pfsync.c index 5db72edc2dab..b75cc4e08029 100644 --- a/sys/netpfil/pf/if_pfsync.c +++ b/sys/netpfil/pf/if_pfsync.c @@ -492,6 +492,10 @@ pfsync_clone_destroy(struct ifnet *ifp) mtx_destroy(&sc->sc_mtx); mtx_destroy(&sc->sc_bulk_mtx); + for (c = 0; c < pfsync_buckets; c++) { + b = &sc->sc_buckets[c]; + mtx_destroy(&b->b_mtx); + } free(sc->sc_buckets, M_PFSYNC); free(sc, M_PFSYNC);