From owner-svn-src-head@FreeBSD.ORG Thu Mar 4 18:56:54 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AF6F9106566B; Thu, 4 Mar 2010 18:56:54 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 5FDEA8FC12; Thu, 4 Mar 2010 18:56:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o24Iqm6A004173; Thu, 4 Mar 2010 11:52:49 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Thu, 04 Mar 2010 11:53:05 -0700 (MST) Message-Id: <20100304.115305.769599705400649806.imp@bsdimp.com> To: scottl@samsco.org From: "M. Warner Losh" In-Reply-To: <9A8644AD-3B92-4BCE-8A51-132F8EA35F7D@samsco.org> References: <20100304.105304.29649700129034.imp@bsdimp.com> <9A8644AD-3B92-4BCE-8A51-132F8EA35F7D@samsco.org> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, ed@freebsd.org Subject: Re: svn commit: r194266 - head/usr.bin/chpass X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Mar 2010 18:56:54 -0000 In message: <9A8644AD-3B92-4BCE-8A51-132F8EA35F7D@samsco.org> Scott Long writes: : On Mar 4, 2010, at 10:53 AM, M. Warner Losh wrote: : > : > In message: : > Scott Long writes: : > : Forcing the entire build to fail if chflags fails breaks installing : > : to an NFS destination. I haven't tested all possible permutations : > : of src vs dest filesystems mounting, but I don't see how it can : > : work over any type of NFS mount. What is the reason for forcing : > : this failure? The NO_FSCHG variable is undocumented, and the : > : failure mode here is pretty useless at helping the user fix the : > : problem. I'd like to re-add the '-' modifier to the chflags : > : command that you removed. : > : > NO_FSCHG variable has been around a long time, and is de-facto : > supported. It will be documented shortly when I get done cleaning up : > build(7). : > : > NO_FSCHG has been the documented way (in examples) for installing over : > NFS for a very long time. It looks to my eye like this change fixed a : > problem with that... : > : > Warner : > : > : : : Every other base package that sets schg does so by allowing chflags to silently fail. My change puts chpass back into conformance with the status quo. Well, maybe for chflags, but not for install. You still need NO_FSCHG if you are installing over NFS, with or without this change... Warner