Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 29 Nov 2012 01:36:41 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Pawel Pekala <pawel@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r307922 - head/astro/viking
Message-ID:  <20121129013641.GA11624@FreeBSD.org>
In-Reply-To: <201211281730.qASHULKQ096841@svn.freebsd.org>
References:  <201211281730.qASHULKQ096841@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 28, 2012 at 05:30:21PM +0000, Pawel Pekala wrote:
> New Revision: 307922
> URL: http://svnweb.freebsd.org/changeset/ports/307922
> 
> -PORTVERSION=	1.3.1
> +PORTVERSION=	1.3.2.1
>  CATEGORIES=	astro
> -MASTER_SITES=	SF
> +MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/1.3.2/

If you need to trim the last number for versions like this one, then
${PORTVERSION:R} can be  your friend.  Less hardcoding of numbers. :)

>  COMMENT=	Program to manage GPS data (tracks, waypoints, etc)

"etc." should always be ended by a full stop (period).

> +USE_XORG=	pixman x11 xau xcomposite xcursor xdamage xdmcp xext \
> +		xfixes xi xinerama xrandr xrender
>  USE_GNOME=	gnomedocutils gtk20
> +USE_ICONV=	yes
>  USE_PERL5_RUN=	yes
> -USE_GETTEXT=	yes
> -USE_GMAKE=	yes
>  GNU_CONFIGURE=	yes
> +USE_GMAKE=	yes

USE_* knobs are a bit unsorted here.

> +OPTIONS_DEFINE=	GEOTAG GPSD
> +OPTIONS_DEFAULT=	GEOTAG
> +GEOTAG_DESC=	Enable Geotag support
> +GPSD_DESC=	Enable realtime GPS tracking

"Enable" word should be avoided in option descriptions per recent agreement.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121129013641.GA11624>