Date: Tue, 14 Jan 2014 01:36:27 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Rusmir Dusko <nemysis@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r338474 - head/net-p2p/libtorrent-rasterbar Message-ID: <20140114013627.GA76343@FreeBSD.org> In-Reply-To: <20140113155007.GA13066@nemysis4now> References: <20140113155007.GA13066@nemysis4now>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 13, 2014 at 04:50:07PM +0100, Rusmir Dusko wrote: > > On Thu, Jan 02, 2014 at 07:47:58PM +0000, Rusmir Dusko wrote: > > > New Revision: 338474 > > > URL: http://svnweb.freebsd.org/changeset/ports/338474 > > > > > > Log: > > > - Bump PORTREVISION > > > - Fix build on 8.x and 9.x > > > - Use USES=compiler:c++11-lang instead of compiler > > > Can you elaborate a bit on the necessity of USES=compiler:c++11-lang here? > > I didn't notice any C++11 features used in the source code; at least base > > GCC builds it just fine. There is a problem with ./configure script: it > > passes -ftemplate-depth=120 option during Boost detection; but that can be > > easily remedied with simple sed(1) script. Would you consider attached > > patch? > > Thanks i will elaborate your patch. Rusmir, with all due respect, it's very hard to read through your emails. Please either pay more attention to punctuation marks, or use standard rules of quoting and order. > This is good > > -CONFIGURE_ARGS+= --disable-debug \ > +CONFIGURE_ARGS= --disable-debug \ > > I don't approve this, because it is needed for successful build on PointyHat > > -USES= compiler:c++11-lang pathfix pkgconfig iconv > +USES= pathfix pkgconfig icon Which changes of the quoted above you did and did not like? Particularly, what's needed for successful build on pointyhat, += in configure args, or c++11 compiler? Also, strictly speaking, "successful build on pointyhat" is not a valid reason, it's just a consequence; underllying technical details is what's important. I'm sure that all of us understand that if port uses C++11 features, it would require modern compiler. (But than again, this port does not seem to use any of them and builds on stable/8 with default GCC 4.2 just fine, modulo that ./configure script.) > This is unnecessary, Clang and GCC have this Option: > > http://clang.llvm.org/docs/genindex.html > > http://gcc.gnu.org/onlinedocs/gcc/C_002b_002b-Dialect-Options.html > > + @${REINPLACE_CMD} -e '/-ftemplate-depth/d' ${WRKSRC}/configure stable/8> gcc -ftemplate-depth=120 ... cc1: error: unrecognized command line option "-ftemplate-depth=120" > Build log on RedPorts is not relevant, important is from PointyHat > > https://redports.org/buildarchive/20140113145200-49735/ > > This build on RedPorts was good but failed on PointyHat, > I think this is too with your diff > > https://redports.org/buildarchive/20140102183201-55841/ Sorry, I don't understand. You say that links to RedPorts is not relevant, and I should see the logs from PointyHat, but give links to redports.org only. I did not find anything interesting via quoted URLs. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140114013627.GA76343>