From owner-svn-src-head@FreeBSD.ORG Sat Dec 21 00:37:51 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BBF45A19; Sat, 21 Dec 2013 00:37:51 +0000 (UTC) Received: from mail-pa0-x22b.google.com (mail-pa0-x22b.google.com [IPv6:2607:f8b0:400e:c03::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7BDB11825; Sat, 21 Dec 2013 00:37:51 +0000 (UTC) Received: by mail-pa0-f43.google.com with SMTP id bj1so3288267pad.16 for ; Fri, 20 Dec 2013 16:37:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=5putG4odMXujIhmJ3KJEwVawrSzkVldsYwpcHPdhFLk=; b=RL5kDK21UgjO7LoovuYlmv4wRkxWSAbdTe2GFUiaL6KhRe742IAj1dy56h9f8xxorr dWUzFGRFN8xa8dmYizaECDMOLfWF95QLiDkSxfFWOqerjG0B6tbXstYAEkV6+1ZRRrXB 2+DYI+KvG9+HImy1iYYzzjYjIqZDla6k+D4Aei+iNdYCaQPxLDCxxm912Ung8EVX01yb b2OMWb5AkLZTutoxFfhP6+xzu7ID79+FuSGl9yAjl8R8hiRI+E2h/iCUfG5JrtR6Whhj d7bPo5+LZF4BSt/0DMQC87KiYjALxOiKOAmBWwfb+yeapKHm9bayWMiHG9FqPy3Pdw1O Cw8A== X-Received: by 10.68.129.99 with SMTP id nv3mr12057358pbb.40.1387586271039; Fri, 20 Dec 2013 16:37:51 -0800 (PST) Received: from zhabar.gateway.2wire.net (76-253-2-5.lightspeed.sntcca.sbcglobal.net. [76.253.2.5]) by mx.google.com with ESMTPSA id pe3sm17143495pbc.23.2013.12.20.16.37.49 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Fri, 20 Dec 2013 16:37:50 -0800 (PST) Date: Fri, 20 Dec 2013 16:37:45 -0800 From: Justin Hibbits To: Howard Su Subject: Re: svn commit: r259668 - head/sys/cddl/dev/fbt Message-ID: <20131220163745.479cb59d@zhabar.gateway.2wire.net> In-Reply-To: References: <201312202318.rBKNIFbS097430@svn.freebsd.org> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.19; powerpc64-portbld-freebsd11.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "svn-src-head@freebsd.org" , Justin Hibbits , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Dec 2013 00:37:51 -0000 On Sat, 21 Dec 2013 08:31:01 +0800 Howard Su wrote: > On Saturday, December 21, 2013, Justin Hibbits wrote: > > > Author: jhibbits > > Date: Fri Dec 20 23:18:14 2013 > > New Revision: 259668 > > URL: http://svnweb.freebsd.org/changeset/base/259668 > > > > Log: > > Fix a couple bugs in FBT PowerPC. Clamp the size to a > > 'instruction size' not > > 'byte size', and fix a typo. > > > > MFC after: 2 weeks > > > > Modified: > > head/sys/cddl/dev/fbt/fbt_powerpc.c > > > > Modified: head/sys/cddl/dev/fbt/fbt_powerpc.c > > > > ============================================================================== > > --- head/sys/cddl/dev/fbt/fbt_powerpc.c Fri Dec 20 21:31:50 2013 > > (r259667) > > +++ head/sys/cddl/dev/fbt/fbt_powerpc.c Fri Dec 20 23:18:14 2013 > > (r259668) > > @@ -219,7 +219,7 @@ fbt_provide_module_function(linker_file_ > > return (0); > > > > instr = (u_int32_t *) symval->value; > > - limit = (u_int32_t *) (symval->value + symval->size); > > + limit = (u_int32_t *) (symval->value + symval->size / > > sizeof(u_int32_t)); > > > > This change doesn't look right to me. symval->value is caddr_t > > (char*). > why add instruction size to it? D'oh, complete brain-o. I had read it as a size field, not a pointer field. Fixed now. - Justin