From owner-freebsd-net@freebsd.org Fri Jun 17 03:05:50 2016 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 871B8A774AC for ; Fri, 17 Jun 2016 03:05:50 +0000 (UTC) (envelope-from matt.joras@gmail.com) Received: from mail-pa0-x22c.google.com (mail-pa0-x22c.google.com [IPv6:2607:f8b0:400e:c03::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 58EC31652; Fri, 17 Jun 2016 03:05:50 +0000 (UTC) (envelope-from matt.joras@gmail.com) Received: by mail-pa0-x22c.google.com with SMTP id b5so23868178pas.3; Thu, 16 Jun 2016 20:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=sqDYN8tlLWFlkmE6nUSz772jlbwVAj/Hlq2wxflMt24=; b=B2trNH5Iz5zzVtrI1sa9nzaLOO+qwAOQFJjXT1w3TKwxb2UsMnupXgmRmhlWWAlqo8 8GA+6FQEOz6x0d86tBHuokMkwwkAHFQaeGnmvc4no99MOiMz8mwqOdf9qrPKCkfkdtbR yA5bEqNaYm5fYRtidIe+gmwrXaIg0eNK9PJudefeF2j4Dw3WIZTaSM2DFvbfz0wf5XVp rhQrVlCvaXjH7JPXVqXJQE/amOMRQPV0UkK5aZWS8vNrNvTSTI5E82jvtiOMx2zGU9lo CdKY4bnW7m141nrgDGizNIvxhpk80tBZM42DH0Xdeg67ishJ9BTMYpCBqsveLt9yMAYd 5NSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=sqDYN8tlLWFlkmE6nUSz772jlbwVAj/Hlq2wxflMt24=; b=Js5EWnKfZDkYf/L5NulNdr5gcJZdbqGlWCGdvid2MAGBeTI62hkDRpLtOIPaw7hUY4 rlQvSZwlgk0myPn4f9CvuogmUVQo0xVmeapZQ9hdneTuWEHDXfbHfYiXC+c09TXCqyup WU9tFSe/Tz0xGPLLnvmJu6tZ1eskoEZhpli5NSo+hw1CHf3hVo4B9+3AL1soS55ma+ac xIzd5iFnlsSNhVB4+I0lTyUKMw3K8GvWls+RclasuKjtGDsmt4Y7PtNqdea8g27/q7oz rCKZNkyXBA7O3Gv9QWHFgxWQ0JsBXUK3DeVviRvVGYyoeXiF6yN7M9V2tpYET2saquUn uTlw== X-Gm-Message-State: ALyK8tJljLsh8VMRjtWlloEBt5E7cH5hcNTR27wdCjxXW7hNYcdHXeuMd5p54Lt3/If73w== X-Received: by 10.66.122.196 with SMTP id lu4mr9143310pab.52.1466132749815; Thu, 16 Jun 2016 20:05:49 -0700 (PDT) Received: from buzzell ([23.252.50.43]) by smtp.googlemail.com with ESMTPSA id g86sm63777809pfd.67.2016.06.16.20.05.48 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 16 Jun 2016 20:05:49 -0700 (PDT) Message-ID: <1466132748.8545.5.camel@gmail.com> Subject: Re: lagg(4): LOR, deadlock and panic From: Matt Joras To: Alan Somers , Sean Bruno Cc: "freebsd-net@freebsd.org" Date: Thu, 16 Jun 2016 20:05:48 -0700 In-Reply-To: References: <459d2639-b490-beee-9cd4-05f38983eaed@freebsd.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2016 03:05:50 -0000 On Tue, 2016-06-14 at 09:26 -0600, Alan Somers wrote: > > I don't know the best answer either.  But while you're in there, are > you interested in fixing any other lagg panics too?  I've written > some > ATF torture tests for lagg, but I haven't checked them into head yet > because most of them quickly panic. > > -Alan We run into if_lagg and if_vlan panics at $WORK all the time in our automation. I've fixed the if_vlan panics and I'm hoping to update this review: https://reviews.freebsd.org/D5825 soon with something that accomodates drivers sleeping in the vlan_*config event handlers (which involves having a global rmlock _and_ sx in if_vlan). I was planning on doing a similar audit/fixing of if_lagg soon when I get the chance. Matt Joras