From owner-cvs-all Sat Oct 28 16:54:17 2000 Delivered-To: cvs-all@freebsd.org Received: from genius.systems.pavilion.net (genesis.tao.org.uk [194.242.131.254]) by hub.freebsd.org (Postfix) with ESMTP id 9F6B437B4F9; Sat, 28 Oct 2000 16:54:10 -0700 (PDT) Received: by genius.systems.pavilion.net (Postfix, from userid 100) id 556329B12; Sun, 29 Oct 2000 00:57:33 +0100 (BST) Date: Sun, 29 Oct 2000 00:57:32 +0100 From: Josef Karthauser To: Matthew Jacob Cc: Tony Finch , Matt Jacob , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/pci isp_pci.c Message-ID: <20001029005732.J64763@pavilion.net> References: <20001029002754.I64763@pavilion.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from mjacob@feral.com on Sat, Oct 28, 2000 at 04:31:29PM -0700 X-NCC-RegID: uk.pavilion Organisation: Pavilion Internet plc, Lees House, 21-23 Dyke Road, Brighton, England Phone: +44-845-333-5000 Fax: +44-845-333-5001 Mobile: +44-403-596893 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, Oct 28, 2000 at 04:31:29PM -0700, Matthew Jacob wrote: > > Gee- I'm sorry- I must have deleted the front end of this mail thread w/o > noticing it. > > I take it I'm being criticised for the informality of the log message. Thanks > for your opinion- I'll try and remember it in the future. If CVS were easier > to use wrt modifying the commit message- I'd change it now (that is, if we had > an adult source management system, this would be easy to fix in retrospect). > > I assume that this is all mostly a theoretical exercise since I don't recall > seeing either of you offer anything substantive, or anything at all, in terms > of improving the code in question. I'd love it if you could devote cycles > improving the code and reviewing the substance - and sending critiques about > *that*, instead of making nits about the commit messages- but I'll try and > make sure the messages meet your approval as well. It seems to me that the > comment about seeing a useful history implies that some of you are actually > paying attention to this corner of the code, which, frankly, given how little > feedback I get about it, is shocking. > > Ta, then... > > -matt Please don't take my comments negatively. They were not meant in any way as a slur or even a complaint, just an observation. It appears that you're not aware, and why should you be, that I'm thinking hard about how to improve our revision control system. I have a restructuring of the CVSROOT/scripts in the wings that I will commit at some point. One of the things that I was talking to Peter and Mark about at the Con was how effectively we can migrate to the possibity of a unique commit id per commit, and retrospectively assigning commit ids for commits back to the beginning of time. That's what I was talking about. My 'please please' plea was to the wider audience. I'm sorry if it seemed that I was having a pot shot at you. Not my intension at all. As a question back to wider audience, do we have a style.commitlogs document anywhere? Maybe this should also be formalised somewhere; there's no hints in the committers guide. Nik? Regards, Joe > > > > > On Thu, Oct 26, 2000 at 03:31:47AM +0000, Tony Finch wrote: > > > Matt Jacob wrote: > > > > > > > > Whoops! Forgot to commit this when I committed the other (turnin on locks) > > > > change. Sorry about that. > > > > > > It seems to me (based on my experience as an Apache core team member > > > and as someone who likes to understand software by looking at how it > > > evolved) that for the purposes of maintaining a useful history, > > > cockups like this should be handled by using the same commit message > > > when committing the missing file(s) as was used in the original > > > commit. Apologies should be posted separately or as an extra note > > > added to the original commit message, instead of replacing all useful > > > information with "whoops, sorry". > > > > I agree. There's a further benefit to this. The only way to > > determine what files were committed at the same time after the fact > > (excluding the commit mail logs) is to use a heuristic based on > > commit message, committer and fuzzy time of day. Please please > > use an exact copy of the commit message where possible otherwise > > the subsequent change will never be rolled into the first commit. > > > > Joe > > > -- Josef Karthauser FreeBSD: How many times have you booted today? Technical Manager Viagra for your server (http://www.uk.freebsd.org) Pavilion Internet plc. [joe@pavilion.net, joe@uk.freebsd.org, joe@tao.org.uk] To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message