From owner-cvs-src@FreeBSD.ORG Mon Jun 12 13:28:24 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A733B16A473; Mon, 12 Jun 2006 13:28:24 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1775543D46; Mon, 12 Jun 2006 13:28:23 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from osx.baldwin.cx (osx.baldwin.cx [192.168.0.15]) (authenticated bits=0) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k5CDSNV4012219; Mon, 12 Jun 2006 09:28:23 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Tom Rhodes Date: Mon, 12 Jun 2006 08:46:51 -0400 User-Agent: KMail/1.9.1 References: <200606070333.k573XmRc067920@repoman.freebsd.org> <200606090853.48604.jhb@freebsd.org> <20060609203802.7cbdf70f.trhodes@FreeBSD.org> In-Reply-To: <20060609203802.7cbdf70f.trhodes@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200606120846.53006.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [192.168.0.1]); Mon, 12 Jun 2006 09:28:23 -0400 (EDT) X-Virus-Scanned: ClamAV 0.87.1/1534/Mon Jun 12 08:30:53 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: grog@freebsd.org, cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: HISTORICAL_MAKE_WORLD (was: cvs commit: src Makefile README) X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jun 2006 13:28:24 -0000 On Friday 09 June 2006 20:38, Tom Rhodes wrote: > On Fri, 9 Jun 2006 08:53:47 -0400 > John Baldwin wrote: > > > On Wednesday 07 June 2006 20:48, Greg 'groggy' Lehey wrote: > > > On Wednesday, 7 June 2006 at 10:51:45 -0400, John Baldwin wrote: > > > > On Tuesday 06 June 2006 23:33, Tom Rhodes wrote: > > > >> trhodes 2006-06-07 03:33:48 UTC > > > >> > > > >> FreeBSD src repository > > > >> > > > >> Modified files: > > > >> . Makefile README > > > >> Log: > > > >> Simply running ``make world'' will bomb unless you dig up the > > > >> undocumented HISTORICAL_MAKE_WORLD variable and set it. Note it > > > >> here so the blow up will not really be a surprise to people who > > > >> read. > > > > > > > > I thought the obfuscation was intentional as very few people should > > > > be doing a 'make world' without a custom DESTDIR these days. > > > > > > Then there's no reason not to document it. > > > > > > Warning: FORCE_ROOT_INSTALL can render your system unusable by > > > overwriting existing configuration files. Do not use it unless you > > > are completely aware of the consequences. > > > > > > And yes, a descriptive name like FORCE_ROOT_INSTALL, not > > > HISTORICAL_MAKE_WORLD. > > > > Describing it would subvert the intended obfuscation. > > > > > > Certainly people new to FreeBSD shouldn't be doing it; only those > > > > with the command hardwired into their brains. We've had > > > > buildworld/installworld since 2.2.5 (or 2.2.6) I think as I've only > > > > had to do a 'make world' once to go from 2.2.2 to 2.2.6. :) > > > > > > FWIW, that's when the rot set in IMO. One of the nice things about > > > FreeBSD *used* to be that to upgrade the system you just needed to do > > > "make world". Now you have a lot more work. > > > > > > The only justification for this regression is that it's really > > > difficult to get everything right. But that's a bug, not a feature. > > > > No, the justification is that 'make world' completely ignores the kernel and > > only handles userland, and an operating system is both a kernel and a > > userland and that users should update those together. If you as a developer > > want to use make world you can either run the two commands back to back or > > you can put I_REALLY_KNOW_WHAT_IM_DOING_AND_WANT_TO_HOSE_MY_MACHINE in > > make.conf or something. However, developers wanting to do this are in the > > _VAST_ minority and I'd much rather cater to the other 99% of the world. > > Hmmm. Perhaps a warning like this and then kill the > HISTORICAL_MAKE_WORLD target and related docs? This warning is too late, you might already have a hosed system at this point. :) -- John Baldwin