From nobody Wed May 7 21:37:08 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zt7rj5KG9z5vKwg; Wed, 07 May 2025 21:37:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Zt7rh4L3gz3m62; Wed, 07 May 2025 21:37:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746653828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=I2WcJIT+indKk5gQw81wPokVWuNMg1696rQzxHsg9oI=; b=ewGsqZjFvSmEFTZE8kSZlXVxFhr9ocQUfVmBeX1wrP3uMlYxDSF7K1LnhVv07wChOIyDD3 0D1HE94cMPnwAwyiTnaDxHuwIosZkEahYUbbPKw34tR7+XNM1enb0VeN3x5T7PDe0h0FK/ Y4er/U5jBnzoe9nc9izSu2JLNR+PTubGJrXsZExAmxrz2dC6n6eWEbq0PWL7i1jWhbBcm7 7tGaMECoZDNj6Zxsb8T1xG65LaqJPGP6Z6oGLSJSoQqu8YgWWEHjjZiEtLh4urvLO9olW/ q3rw3RF6HfnZC352xynQHtq7aLlaHE2iWoC7n+kjLEX9AlsbVnSUMR50HUsotA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746653828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=I2WcJIT+indKk5gQw81wPokVWuNMg1696rQzxHsg9oI=; b=ZfQA6zeRlnhCFyqlVizoJK0xDtPOsyb8FFOcRaJS7DsjovT+mwk/DUAkVwXw9S1ndc3MtR S/oKeUdAhG8rUsLi4+VKmvpgExspoAsw3P2GZTkjjri0JJl2ObNaTuGXp7lwzqQHD/19An xWJKa+nNCJRx4z8JlwZLgm5Kh08zGFgDr6qyYiZvd6205uOIiSrBOHtOk1N3ZlubUOPwxl vYr3ifXr5Qbcy6gcqwGPnHk0XBWlhSZMiAD+wZYb17QKGSBo2MNKnzwTzk3S3/AVNWz0GM HESwLe/MwTwhBJIwVHM1oP17yP/z5AXUwou9uZKOOKI1Y/lGynPmJBB9pth5mw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1746653828; a=rsa-sha256; cv=none; b=phCG9D/f8B8NPXv9u3J+JJr7wK0fwr5zbveXR/zwm3GiRWPOJlMcO1V9yRtflmLnaYTG2I Qgei47GPWkG6VQYL9sdkUbQLJH8m1ELXaw7SnFIBfL23iMOlY1PnMFQaFCj/3Oc/a4h1Ql IQe+U9/8/KhCjENk+oRENf85/3qQcGf5YOE2NseA3LfYZPtoiv78Gy9XWJ6UZZcvpHi5ug 0u6CX0aGUEgxQGEca6552pNHkBV2PyiNVe9kIe+zFHbgtCLjCpy3U4/fl7ImXAcvF80kNK 0VkJDu3uNw27zaj+qQYXPMfwy4HLkYyusEk665wW2HiX0PrT9E+AfvrjsvoreA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Zt7rh0TtSzmwt; Wed, 07 May 2025 21:37:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 547Lb83Q092025; Wed, 7 May 2025 21:37:08 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 547Lb8Oh092022; Wed, 7 May 2025 21:37:08 GMT (envelope-from git) Date: Wed, 7 May 2025 21:37:08 GMT Message-Id: <202505072137.547Lb8Oh092022@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: a945c21a6101 - main - umass: Fail SYNCHRONIZE_CACHE for UFI List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a945c21a61019691f526fe8feaf0ec413977dbd0 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=a945c21a61019691f526fe8feaf0ec413977dbd0 commit a945c21a61019691f526fe8feaf0ec413977dbd0 Author: Warner Losh AuthorDate: 2025-05-07 16:07:17 +0000 Commit: Warner Losh CommitDate: 2025-05-07 21:36:54 +0000 umass: Fail SYNCHRONIZE_CACHE for UFI Just go ahead and fail SYNCHRONIZE_CACHE commands for UFI. This standard doesn't have a cache to flush, and the upper layers (aka da) will notice sync cache failed and won't send it again. Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D49468 --- sys/dev/usb/storage/umass.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sys/dev/usb/storage/umass.c b/sys/dev/usb/storage/umass.c index 8922b3770e6a..bdbe04ce3bbd 100644 --- a/sys/dev/usb/storage/umass.c +++ b/sys/dev/usb/storage/umass.c @@ -2825,12 +2825,11 @@ umass_ufi_transform(struct umass_softc *sc, uint8_t *cmd_ptr, /* * SYNCHRONIZE_CACHE isn't supported by UFI, nor should it be - * required for UFI devices, so it is appropriate to fake - * success. + * required for UFI devices. Just fail it, the upper layers + * know what to do. */ case SYNCHRONIZE_CACHE: - return (2); - + return (0); default: DPRINTF(sc, UDMASS_SCSI, "Unsupported UFI " "command 0x%02x\n", cmd_ptr[0]);