From owner-freebsd-hackers Tue Aug 8 01:45:10 1995 Return-Path: hackers-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.11/8.6.6) id BAA07574 for hackers-outgoing; Tue, 8 Aug 1995 01:45:10 -0700 Received: from ibp.ibp.fr (ibp.ibp.fr [132.227.60.30]) by freefall.cdrom.com (8.6.11/8.6.6) with ESMTP id BAA07557 for ; Tue, 8 Aug 1995 01:45:04 -0700 From: simon@masi.ibp.fr Received: from blaise.ibp.fr (blaise.ibp.fr [132.227.60.1]) by ibp.ibp.fr (8.6.12/jtpda-5.0) with ESMTP id KAA01116 for ; Tue, 8 Aug 1995 10:44:31 +0200 Received: from (uucp@localhost) by blaise.ibp.fr (8.6.12/jtpda-5.0) with UUCP id KAA07840 for freebsd-hackers@freebsd.org; Tue, 8 Aug 1995 10:44:30 +0200 Received: (simon@localhost) by neuromancer.ibp.fr (8.6.11/bbj-1.0) id KAA00358 for freebsd-hackers@freebsd.org; Tue, 8 Aug 1995 10:42:21 +0200 Message-Id: <199508080842.KAA00358@neuromancer.ibp.fr> Subject: Re: patch adding the 'noauto' switch to 'mount' To: freebsd-hackers@freebsd.org Date: Tue, 8 Aug 1995 10:42:21 +0200 (MET DST) In-Reply-To: <199508080019.RAA01843@gndrsh.aac.dev.com> from "Rodney W. Grimes" at Aug 7, 95 05:19:40 pm X-Mailer: ELM [version 2.4 PL23beta2] Content-Type: text Content-Length: 900 Sender: hackers-owner@freebsd.org Precedence: bulk Hi, > > +#define MNT_NOAUTO 0x00000003 /* don't mount with 'mount -a' */ > > WRONG VALUE!!! These are bit fields, not integers. MNT_NOAUTO is now > the same as -o ro,sync :-(. MNT_NOAUTO does _not_ belong on in this > set of bit patterns, the kernel could care less about this! We are also > out of bits for some structures that try to store this value :-(. Argh :-O You're right on both points. The kernel doesn't even see that flag, since it's processed prior to the actual mounting of the FS, and it would be a Bad Thing to waste a precious bit-mask value on it (the first available one is 0x04000000). We need to have MNT_NOAUTO defined, though. how about : #define MNT_NOAUTO 0x00000000 This shouldn't interfere with the existing flags (right ?) and it wouldn't really waste a value. What do you think ? Any other ideas ? Julien -- http://www-masi.ibp.fr/~Julien.Simon