From owner-freebsd-scsi@freebsd.org Mon Jun 4 10:52:04 2018 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A1438FF3E8C for ; Mon, 4 Jun 2018 10:52:04 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 3CEA67FF7E for ; Mon, 4 Jun 2018 10:52:04 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: by mailman.ysv.freebsd.org (Postfix) id F0302FF3E8B; Mon, 4 Jun 2018 10:52:03 +0000 (UTC) Delivered-To: scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CB47BFF3E8A for ; Mon, 4 Jun 2018 10:52:03 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mx0.gentlemail.de (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FAEA7FF76 for ; Mon, 4 Jun 2018 10:52:03 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mh0.gentlemail.de (mh0.gentlemail.de [IPv6:2a00:e10:2800::a135]) by mx0.gentlemail.de (8.14.5/8.14.5) with ESMTP id w54Aq0Nk018668; Mon, 4 Jun 2018 12:52:00 +0200 (CEST) (envelope-from freebsd@omnilan.de) Received: from titan.inop.mo1.omnilan.net (s1.omnilan.de [217.91.127.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mh0.gentlemail.de (Postfix) with ESMTPSA id 0CD25797; Mon, 4 Jun 2018 12:51:59 +0200 (CEST) Subject: =?UTF-8?Q?What_is_ENXIO_=e2=80=93_MSI_allocation_regression_in_:[Wa?= =?UTF-8?Q?s_Re:_svn_commit:_r321714_-_in_head/sys/dev:_mpr_mps]?= From: Harry Schmalzbauer To: Scott Long , scsi@freebsd.org References: <201707300653.v6U6rwLN099096@repo.freebsd.org> <597DA578.6030101@omnilan.de> <597F56A8.1060603@omnilan.de> <59804C8C.1020003@omnilan.de> Organization: OmniLAN Message-ID: Date: Mon, 4 Jun 2018 12:51:59 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <59804C8C.1020003@omnilan.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]); Mon, 04 Jun 2018 12:52:00 +0200 (CEST) X-Milter: Spamilter (Reciever: mx0.gentlemail.de; Sender-ip: ; Sender-helo: mh0.gentlemail.de; ) X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jun 2018 10:52:04 -0000 Am 01.08.2017 um 11:40 schrieb Harry Schmalzbauer: > Bezüglich Scott Long's Nachricht vom 31.07.2017 18:56 (localtime): > > … >>> I'd like to report one I hadn't expected: >>> >>> mps0: port 0x4000-0x40ff mem 0xc3bc0000-0xc3bc3fff,0xc3b80000-0xc3bbffff irq 19 at device 0.0 on pci7 >>> >>> mps0: Firmware: 20.00.04.00, Driver: 21.02.00.00-fbsd >>> mps0: IOCCapabilities: >>> 185c >>> mps0: Cannot allocate INTx interrupt >>> mps0: mps_iocfacts_allocate failed to setup interrupts >>> mps0: mps_attach IOC Facts based allocation failed with error 6 >>> panic: resource_list_release: resource entry is not busy >>> cpuid = 6 >>> KDB: stack backtrace: >>> #0 0xffffffff805e32d7 at kdb_backtrace+0x67 >>> #1 0xffffffff805a1d26 at vpanic+0x186 >>> #2 0xffffffff805a1b93 at panic+0x43 >>> #3 0xffffffff805d71c6 at resource_list_release+0x1c6 >>> #4 0xffffffff8040fef1 at mps_pci_free+0xe1 >>> #5 0xffffffff8040fa23 at mps_pci_attach+0x1b3 >>> #6 0xffffffff805d6594 at device_attach+0x3a4 >>> #7 0xffffffff805d774d at bus_generic_attach+0x3d >>> #8 0xffffffff8044ac05 at pci_attach+0xd5 >>> #9 0xffffffff805d6594 at device_attach+0x3a4 >>> #10 0xffffffff805d774d at bus_generic_attach+0x3d >>> #11 0xffffffff80364761 at acpi_pcib_pci_attach+0xa1 >>> #12 0xffffffff805d6594 at device_attach+0x3a4 >>> #13 0xffffffff805d774d at bus_generic_attach+0x3d >>> #14 0xffffffff8044ac05 at pci_attach+0xd5 >>> #15 0xffffffff805d6594 at device_attach+0x3a4 >>> #16 0xffffffff805d774d at bus_generic_attach+0x3d >>> #17 0xffffffff80363e4d at acpi_pcib_acpi_attach+0x42d >>> Uptime: 1s > … > >> Fixed in r321799, thanks for the report. > Fix confiremd; merged together with r321733 (and 321737) to 11.1 and > panic vanished. Late in the 11.2 phase, I identified this commit as a regression for MSI (non-x) alloctaion. I have an idea what probably causes the problem here (INTx allocation, although MSI (and MSI-x) capability): disable_msix is not 0 (I need to disable MSI-x because of ESXi-passthru…). Corresponding lines: {         device_t dev;         int error, msgs;         dev = sc->mps_dev;         error = 0;         msgs = 0;         if ((sc->disable_msix == 0) &&             ((msgs = pci_msix_count(dev)) >= MPS_MSI_COUNT))                 error = mps_alloc_msix(sc, MPS_MSI_COUNT);         if ((error != 0) && (sc->disable_msi == 0) &&             ((msgs = pci_msi_count(dev)) >= MPS_MSI_COUNT))                 error = mps_alloc_msi(sc, MPS_MSI_COUNT);         if (error != 0)                 msgs = 0;         sc->msi_msgs = msgs;         return (error); } Before r321714, error was assigned ENXIO, which, if != 0, could help make me understand the problem. Unfortunately I have no idea what ENXIO means, where it's defined and most important, how to find the place where the declaration/definition happens.  Only joe and vi available here, any hints highly appreciated. I can confirm that MSI allocation works with mps.ko_21.02.00.00-fbsd-r321415 with my ESXi-passthru-non_msi-x setup. Although the dirver emits no message that an MSI was allocated, like toher drivers do.  That's a cosmetic one though. But the MSI->INTx regression is a severe one for me, which I'd like to fix myself but I'm missing so many fundamental skills :-( Thanks, -harry