From owner-freebsd-current@FreeBSD.ORG  Fri Aug  1 10:15:21 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B42E337B401
	for <current@freebsd.org>; Fri,  1 Aug 2003 10:15:21 -0700 (PDT)
Received: from wall.polstra.com (wall-gw.polstra.com [206.213.73.130])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8CC8B43F75
	for <current@freebsd.org>; Fri,  1 Aug 2003 10:15:20 -0700 (PDT)
	(envelope-from jdp@polstra.com)
Received: from strings.polstra.com (strings.polstra.com [206.213.73.20])
	by wall.polstra.com (8.12.3p2/8.12.3) with ESMTP id h71HFDfK063067
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO);
	Fri, 1 Aug 2003 10:15:13 -0700 (PDT)
	(envelope-from jdp@strings.polstra.com)
Received: (from jdp@localhost)
	by strings.polstra.com (8.12.6/8.12.6/Submit) id h71HFCBe071755;
	Fri, 1 Aug 2003 10:15:12 -0700 (PDT)
	(envelope-from jdp)
Date: Fri, 1 Aug 2003 10:15:12 -0700 (PDT)
Message-Id: <200308011715.h71HFCBe071755@strings.polstra.com>
To: current@freebsd.org
From: John Polstra <jdp@polstra.com>
In-Reply-To: <1059741739.39578.67.camel@rocklobster.openet-telecom.lan>
References: <3F2A2B17.4020700@tagnet.ru>
	<1059741739.39578.67.camel@rocklobster.openet-telecom.lan>
Organization: Polstra & Co., Seattle, WA
X-Bogosity: No, tests=bogofilter, spamicity=0.268692, version=0.11.2
cc: pmedwards@eircom.net
Subject: Re: bge & vlan stranges
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Aug 2003 17:15:22 -0000

In article <1059741739.39578.67.camel@rocklobster.openet-telecom.lan>,
Peter Edwards  <pmedwards@eircom.net> wrote:
> Hm. A bit of a stab in the dark, but from sys/dev/bge/if_bge.c, line
> 3185 (on 5.1 release, 2399)
> 
> >         /* Specify MTU. */
> >         CSR_WRITE_4(sc, BGE_RX_MTU, ifp->if_mtu +
> >             ETHER_HDR_LEN + ETHER_CRC_LEN);
> > 
> > 
> Wonder if this should be
>   
> >         /* Specify MTU. */
> >         CSR_WRITE_4(sc, BGE_RX_MTU, ifp->if_mtu +
> >             ETHER_HDR_LEN + ETHER_CRC_LEN + ETHER_VLAN_ENCAP_LEN);
> > 
> 
> Given that bge advertises IFCAP_VLAN_MTU??

Good guess, but the approved way of doing it is to add this code
near the point where IFCAP_VLAN_MTU is set:

    ifp->if_data.ifi_hdrlen = sizeof(struct ether_vlan_header);

See "sys/dev/fxp/if_fxp.c" for an example that works.

John
-- 
  John Polstra
  John D. Polstra & Co., Inc.                        Seattle, Washington USA
  "Two buttocks cannot avoid friction."                     -- Malawi saying