From owner-svn-ports-all@freebsd.org Tue Oct 20 07:21:44 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 920AEA19460; Tue, 20 Oct 2015 07:21:44 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 85A551846; Tue, 20 Oct 2015 07:21:44 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 84D6B18CD; Tue, 20 Oct 2015 07:21:44 +0000 (UTC) Date: Tue, 20 Oct 2015 07:21:44 +0000 From: Alexey Dokuchaev To: Bartek Rutkowski Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r373471 - in head/editors/sublime3: . files Message-ID: <20151020072144.GA85130@FreeBSD.org> References: <201411262346.sAQNkcjt044067@svn.freebsd.org> <20141127084320.GA28314@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141127084320.GA28314@FreeBSD.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Oct 2015 07:21:44 -0000 On Thu, Nov 27, 2014 at 08:43:20AM +0000, Alexey Dokuchaev wrote: > Hi, > > Few observations, if you allow... > > On Wed, Nov 26, 2014 at 11:46:38PM +0000, Bartek Rutkowski wrote: > > New Revision: 373471 > > URL: https://svnweb.freebsd.org/changeset/ports/373471 > > QAT: https://qat.redports.org/buildarchive/r373471/ > > > [...] > > > +%%DATADIR%%/sublime_text $* > > $* is wrong, should be "$@" (yes, with quotes). Otherwise it won't handle > parameters with spaces etc. correctly. It took us little less than one year to fix a small bug (see r399802). ./danfe