From owner-cvs-all@FreeBSD.ORG Wed Jan 14 19:46:34 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 373A716A4CE; Wed, 14 Jan 2004 19:46:34 -0800 (PST) Received: from mail.chesapeake.net (chesapeake.net [208.142.252.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7E9B343D66; Wed, 14 Jan 2004 19:46:32 -0800 (PST) (envelope-from jroberson@chesapeake.net) Received: from localhost (jroberson@localhost) by mail.chesapeake.net (8.11.6/8.11.6) with ESMTP id i0F3kVk62754; Wed, 14 Jan 2004 22:46:31 -0500 (EST) (envelope-from jroberson@chesapeake.net) Date: Wed, 14 Jan 2004 22:46:31 -0500 (EST) From: Jeff Roberson To: Don Lewis In-Reply-To: <200401142238.i0EMc3HB035466@repoman.freebsd.org> Message-ID: <20040114224559.K36463-100000@mail.chesapeake.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/linux linux_util.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jan 2004 03:46:34 -0000 On Wed, 14 Jan 2004, Don Lewis wrote: > truckman 2004/01/14 14:38:03 PST > > FreeBSD src repository > > Modified files: > sys/compat/linux linux_util.c > Log: > VOP_GETATTR() wants the vnode passed to it to be locked. Instead > of adding the code to lock and unlock the vnodes and taking care > to avoid deadlock, simplify linux_emul_convpath() by comparing the > vnode pointers directly instead of comparing their va_fsid and > va_fileid attributes. This allows the removal of the calls to > VOP_GETATTR(). I'm not sure that the vnode pointer compare works in the case of device aliasing. Any comments? Cheers, Jeff > > Revision Changes Path > 1.24 +1 -13 src/sys/compat/linux/linux_util.c >