From owner-svn-ports-head@freebsd.org  Tue Jul 24 16:15:21 2018
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 52428104FB1E;
 Tue, 24 Jul 2018 16:15:21 +0000 (UTC) (envelope-from kp@krion.cc)
Received: from krion.cc (krion.cc [148.251.235.209])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id E4C9174FDA;
 Tue, 24 Jul 2018 16:15:20 +0000 (UTC) (envelope-from kp@krion.cc)
Date: Tue, 24 Jul 2018 18:15:07 +0200
From: Kirill Ponomarev <kp@krion.cc>
To: Alexey Dokuchaev <danfe@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r475258 - in head/net/sniproxy: . files
Message-ID: <20180724161506.GA79501@krion.cc>
References: <201807241450.w6OEoXZ6077220@repo.freebsd.org>
 <20180724160850.GA57423@FreeBSD.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="AhhlLboLdkugWU4S"
Content-Disposition: inline
In-Reply-To: <20180724160850.GA57423@FreeBSD.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Jul 2018 16:15:21 -0000


--AhhlLboLdkugWU4S
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 07/24, Alexey Dokuchaev wrote:
> On Tue, Jul 24, 2018 at 02:50:33PM +0000, Kirill Ponomarev wrote:
> > New Revision: 475258
> > URL: https://svnweb.freebsd.org/changeset/ports/475258
> >=20
> > Log:
> >   Utilize SOCK_NONBLOCK instead of O_NONBLOCK
> >=20
> > Added: head/net/sniproxy/files/patch-src_connection.c
> > ...
> > +-                    O_NONBLOCK);
> > ++                    SOCK_NONBLOCK);
>=20
> It would be nice if commit message also included the rationale for this
> change (per our 30%-what-70%-why rule).

accept4() is using SOCK_NONBLOCK on FreeBSD instead of O_NONBLOCK
which is a case on Linux.

--AhhlLboLdkugWU4S
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEJCHRFhEAQujKni1pDyI9/LMCykUFAltXUIoACgkQDyI9/LMC
ykWEUAgAjfjaFtx0D2h8aaIJ47t9zDYk6PEbsI40yF89HZRbJq6IdK6vdOjOUSOE
bjeRSs+tNxPWPGWZBQjaKVGs48Y0RoJxh0rcHZqWt7x16iUpHCwq7knN+UWO/B8n
DatS8LhyPF0T7+qe5SjXwqIEgMcU6sFH0Kw+wL2zlMNyy2FO99FZP5PbSMfRINFi
jl2ovg1HpsAdGE6o34S77BiyEjSkqwePC9x40UlzxJzvvLemsFTAgF0dyZfQKcNw
IgSt/VGOZ9ptQkaLDZEzMr+xyOuPFjc3Zusp1kryWaAneQhUY6kULoeOEcTsrJLi
jIlQX71s+M9GQaxBOpsGUS3l7Oc21Q==
=Fkge
-----END PGP SIGNATURE-----

--AhhlLboLdkugWU4S--