Date: Sat, 31 Oct 2020 16:30:53 -0500 From: "Brandon Bergren" <bdragon@FreeBSD.org> To: "Brandon Bergren" <bdragon@FreeBSD.org>, "Ed Maste" <emaste@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: =?UTF-8?Q?Re:_svn_commit:_r367209_-_in_head:_contrib/elftoolchain/readel?= =?UTF-8?Q?f_usr.bin/readelf?= Message-ID: <47495073-df63-404d-8a3b-af2241e12f9b@www.fastmail.com> In-Reply-To: <4468e66d-2615-48a7-bdde-90f9a1266bda@www.fastmail.com> References: <202010311527.09VFRjNx098403@repo.freebsd.org> <4468e66d-2615-48a7-bdde-90f9a1266bda@www.fastmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Oct 31, 2020, at 3:03 PM, Brandon Bergren wrote: > This appears to have broken the build on platforms with a 32 bit > size_t, given the current state of the tinderbox. > > On Sat, Oct 31, 2020, at 10:27 AM, Ed Maste wrote: > > Author: emaste > > Date: Sat Oct 31 15:27:45 2020 > > New Revision: 367209 > > URL: https://svnweb.freebsd.org/changeset/base/367209 > > > This seems more correct to me: It's not like it could have been larger than size_t anyway, since there is no way to malloc more than that anyway. Index: contrib/elftoolchain/readelf/readelf.c =================================================================== --- contrib/elftoolchain/readelf/readelf.c (revision 367230) +++ contrib/elftoolchain/readelf/readelf.c (working copy) @@ -6909,8 +6909,8 @@ * Returns true if sucessful, false otherwise. */ static bool decompress_section(struct section *s, - unsigned char *compressed_data_buffer, uint64_t compressed_size, - unsigned char **ret_buf, uint64_t *ret_sz) + unsigned char *compressed_data_buffer, size_t compressed_size, + unsigned char **ret_buf, size_t *ret_sz) { GElf_Shdr sh;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47495073-df63-404d-8a3b-af2241e12f9b>