From owner-freebsd-mips@freebsd.org Fri Oct 20 23:47:18 2017 Return-Path: Delivered-To: freebsd-mips@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E9EB1E42CD2 for ; Fri, 20 Oct 2017 23:47:18 +0000 (UTC) (envelope-from yamori813@yahoo.co.jp) Received: from nh501-vm4.bullet.mail.kks.yahoo.co.jp (nh501-vm4.bullet.mail.kks.yahoo.co.jp [183.79.56.134]) by mx1.freebsd.org (Postfix) with SMTP id 8467A6A468 for ; Fri, 20 Oct 2017 23:47:18 +0000 (UTC) (envelope-from yamori813@yahoo.co.jp) Received: from [183.79.100.139] by nh501.bullet.mail.kks.yahoo.co.jp with NNFMP; 20 Oct 2017 23:44:08 -0000 Received: from [183.79.101.63] by t502.bullet.mail.kks.yahoo.co.jp with NNFMP; 20 Oct 2017 23:44:08 -0000 Received: from [127.0.0.1] by omp507.mail.kks.yahoo.co.jp with NNFMP; 20 Oct 2017 23:44:08 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 465239.62174.bm@omp507.mail.kks.yahoo.co.jp Received: (qmail 95287 invoked by uid 60001); 20 Oct 2017 23:44:08 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.jp; s=yj20110701; t=1508543048; bh=/k4x8PPvkkFDorGhXhS6mxyrgN71H72+lCFUD9cht4M=; h=Message-ID:X-YMail-OSG:Received:X-Mailer:X-YMail-JAS:References:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=pEUIHgm9KufqRJPF3q5/z50G56noCcCQpolw8Pb+AbChXrlE+Jrp3zyw17dfvBwz6V1Orzep1rkSnF1MihE4S0QbqHhheMp5gxAenZD3f4qFoLEnPeTcwLy2q9jAWi9qtbFCDfJMuM4U+NERJK+U3f/AZPehZlZojkpA8MNs5Ao= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=yj20110701; d=yahoo.co.jp; h=Message-ID:X-YMail-OSG:Received:X-Mailer:X-YMail-JAS:References:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=WYS4N6qEupMazwTTPvkIEA4gt0QmOLQ5wx6SbHgNoIoibjrPF0RcDz0IBOKBhV7Zs1EQ8JonlNKbSzMv89unCDpGoizopSqnPfi87zC+Hhm47kP303+ZOlVWMjKvUThrqZIK6rhvzT7BLTxYM8hcjx+5CBOExLGhapuuh1RL/YY=; Message-ID: <104081.95158.qm@web101711.mail.ssk.yahoo.co.jp> X-YMail-OSG: OrUPL.8VM1nJw.30P_Baz0lRd6mgi4RThMas8jGuxijXz07vradZFX9SBNt8tacMBpcNKVGm8IHPCBLlMr4p5dmZMjKkLfed44hWWXiUNb5BX5dlgEhc8mKNHKLsaSuIudtXx6dUfa_YVma8C8d5ZrkvFFy0uhautmUZq.jMaZmmBGce7gM_6j362ymGyRj_PloCXuP5G_jP4LKYVNX_MD1sFPXq.lbAgHeMLReRkitn532UxCrrzgYXFM0MkntVkrDco7fJ_3nALqwVbjTi20sPm6.RwHj7rxDt8IvWEr.SKpBDMZe4YAAdE5fXOahptzIuppTCVKHJQOqU16gCRHinavYd8bVkCP76iUwdV9PVSAAnH6.d1iKACXT1o9B_57nbjEd85jBCBoztz5bcyW464_3ROwHNuw7g6GGE3GCvO5ZvpcVamqts6hikb7wpfjstDPo.10bdc6sPhroXH7gq5urXsF7BNtj2SMEq3gBluCUHaUs_0Pc3bd6G63lZ6nk9CaKA0_ufXXP3F3LbGGnxKxfHbQ4jR.t5GNX8vL9r.h2xFzvZbryNSopdr7Yma7jzT_qCW0CHqc1z_l_RlPoCrUBjtPyWPX0O4Adj Received: from [61.23.25.155] by web101711.mail.ssk.yahoo.co.jp via HTTP; Sat, 21 Oct 2017 08:44:07 JST X-Mailer: YahooMailWebService/0.8.111_74 X-YMail-JAS: 1JIzb4IVM1kGzPnJpMOWIzgX1ZD1EnET0NLJp7Y2rIDAGiYkGfPAfWU19r7Fe477mWY59XUkH.UgqzZ1T4h9rx484_TYFr7H4JpzD8vghITM3vtyIyMQHKMnGdDVDEXYWQY4 References: <641147.96869.qm@web101704.mail.ssk.yahoo.co.jp> <1508511627.1383.48.camel@freebsd.org> <405153.18836.qm@web101719.mail.ssk.yahoo.co.jp> Date: Sat, 21 Oct 2017 08:44:07 +0900 (JST) From: Mori Hiroki Reply-To: Mori Hiroki Subject: Re: about iicdev_writeto() on ralink soc To: Ian Lepore Cc: "freebsd-mips@freebsd.org" In-Reply-To: <405153.18836.qm@web101719.mail.ssk.yahoo.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Oct 2017 23:47:19 -0000 Hi=0A=0AFYI=0A=0AThis is RT2880 i2c signal by my driver code.=0A=0Ahttps://= flic.kr/p/ZC3HQZ=0A=0A=0A----- Original Message -----=0A> From: Mori Hiroki= =0A> To: Ian Lepore =0A> Cc: "free= bsd-mips@freebsd.org" =0A> Date: 2017/10/21, Sat = 08:04=0A> Subject: Re: about iicdev_writeto() on ralink soc=0A> =0A> Hi=0A>= =0A> =0A> ----- Original Message -----=0A>> From: Ian Lepore =0A>> To: Mori Hiroki =0A>> Cc: "freebsd-mips= @freebsd.org" =0A>> Date: 2017/10/21, Sat 00:00= =0A>> Subject: Re: about iicdev_writeto() on ralink soc=0A>> =0A>> On Fri= , 2017-10-20 at 20:24 +0900, Mori Hiroki wrote:=0A>>> =A0 Hi=0A>>> =0A>>> = =A0 I make mips mediatek iic driver. Mediatek(Ralink) soc(RT2880=A0and=A0= =0A>>> =A0 RT3050) is not support=A0nostop option at I2C device. This soc i= 2c=0A>>> =A0 device is set transfer=A0length and automatically=A0send stop.= And=0A>>> =A0 Always send device address at first byte.=0A>>> =0A>>> =A0 y= our added=A0iicdev_writeto() not work in these soc i2c device.=0A>>> =0A>>>= =0A>>> =0A>>> =A0 https://svnweb.freebsd.org/base?view=3Drevision&revision= =3D321583=0A>>> =0A>>> =0A>>> =A0 Could you please change single transfer i= n=A0iicdev_writeto() at=0A>>> =A0 iiconf.c.=0A>>> =0A>>> =A0 Regards=0A>>> = =0A>>> =A0 Hiroki Mori=0A>> =A0=0A> =0A> Thanks check RT datasheet.=0A> =0A= >> iicdev_writeto() does the correct sequence of operations.=0A>> =0A>> I= think if you set the ADDRDIS bit in the device control register and=0A>> = ignore the NOSTOP flag in the messages, it will work for most slave=0A>> d= evices. =A0Some slave devices require a repeat-start to work correctly,=0A>= > and those will never work right on a controller like this.=0A>> =0A>> -= - Ian=0A>> =0A> =0A> No.=0A> =0A> Ralink Datasheet is very confuse. ADDRDIR= is register address disable.=0A> DEVADDIS is device address disable.=A0=0A= > =0A> If not set=A0DEVADDIS and=A0ADDRDIR then=0A> =0A> = =A0=A0 ...=0A> =0A> If set ADDRDIR then=A0=0A> =0A>= ...=0A> =0A> If set DEVADDIS then ignore ADDRDIR= =0A> =0A> ...=0A> =0A> always two more byte send = this soc.=0A> =0A> Driver review is this.=0A> =0A> https://reviews.freebsd.= org/D12736=0A> =0A> =0A> Thanks=0A> =0A> Hiroki Mori=0A> __________________= _____________________________=0A> freebsd-mips@freebsd.org mailing list=0A>= https://lists.freebsd.org/mailman/listinfo/freebsd-mips=0A> To unsubscribe= , send any mail to =0A> "freebsd-mips-unsubscribe@freebsd.org"=0A>