From owner-freebsd-gecko@freebsd.org Wed Nov 29 12:21:39 2017 Return-Path: Delivered-To: freebsd-gecko@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5AE02E52939 for ; Wed, 29 Nov 2017 12:21:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 42F3572085 for ; Wed, 29 Nov 2017 12:21:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 3F603E52938; Wed, 29 Nov 2017 12:21:39 +0000 (UTC) Delivered-To: gecko@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3F092E52937 for ; Wed, 29 Nov 2017 12:21:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2DEC672084 for ; Wed, 29 Nov 2017 12:21:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vATCLdRB045760 for ; Wed, 29 Nov 2017 12:21:39 GMT (envelope-from bugzilla-noreply@freebsd.org) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: gecko@FreeBSD.org Subject: maintainer-approval requested: [Bug 223964] bsd.gecko.mk: use ${ECHO_CMD} in post-patch-SNDIO-on : [Attachment 188390] bsd.gecko.mk.diff Date: Wed, 29 Nov 2017 12:21:39 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gecko@FreeBSD.org X-Bugzilla-Flags: Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-gecko@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Gecko Rendering Engine issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2017 12:21:39 -0000 Tobias Kortkamp has asked gecko@FreeBSD.org for maintainer-approval: Bug 223964: bsd.gecko.mk: use ${ECHO_CMD} in post-patch-SNDIO-on https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D223964 Attachment 188390: bsd.gecko.mk.diff https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D188390&action=3Dedit --- Description --- Currently ${ECHO} is used which is problematic when it's set to 'true' e.g. when using `make -s`. This is probably only a problem when compiling Gecko ports with TEST=3Don.