From owner-cvs-sys Sun Dec 22 17:24:47 1996 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id RAA01007 for cvs-sys-outgoing; Sun, 22 Dec 1996 17:24:47 -0800 (PST) Received: (from jkh@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id RAA01000; Sun, 22 Dec 1996 17:24:46 -0800 (PST) Date: Sun, 22 Dec 1996 17:24:46 -0800 (PST) From: "Jordan K. Hubbard" Message-Id: <199612230124.RAA01000@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/i386/isa if_ze.c if_zp.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 96/12/22 17:24:46 Modified: sys/i386/isa if_ze.c if_zp.c Log: Someone needs to teach Nate about the C pre-processor in general and the workings of #error in particular. He also broke the 2.2 build with this change, leading me to wonder whether or not the changes were ever even tested. Folks, I'm happy to see people work directly on 2.2 like this and will continue to encourage Nate to make direct commits, but please TEST before committing! I think that's a more than reasonable prerequisite, and this code could never have worked at all, leading me to believe that Nate skipped this most basic of steps. Revision Changes Path 1.36 +2 -2 src/sys/i386/isa/if_ze.c 1.30 +2 -2 src/sys/i386/isa/if_zp.c