From owner-svn-ports-head@freebsd.org Tue Nov 22 11:58:55 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 53FF3C4F282; Tue, 22 Nov 2016 11:58:55 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id DC6B318F9; Tue, 22 Nov 2016 11:58:54 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id D9A27BDD0B; Tue, 22 Nov 2016 12:58:50 +0100 (CET) Received: from ogg.in.absolight.net (ogg.in.absolight.net [79.143.241.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by prod2.absolight.net (Postfix) with ESMTPSA id A88CCBDC86; Tue, 22 Nov 2016 12:58:50 +0100 (CET) Subject: Re: svn commit: r426759 - in head/databases/xapian-core: . files To: Raphael Kubo da Costa References: <201611212126.uALLQxT0063108@repo.freebsd.org> <86oa17lt6j.fsf@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: Mathieu Arnold Organization: Absolight / The FreeBSD Foundation Message-ID: <683d02ff-4117-508f-8a66-3f1712043009@FreeBSD.org> Date: Tue, 22 Nov 2016 12:58:48 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <86oa17lt6j.fsf@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="i2nONGUpsM4Rp4ef8PsBnQnuLOitVSAFg" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Nov 2016 11:58:55 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --i2nONGUpsM4Rp4ef8PsBnQnuLOitVSAFg Content-Type: multipart/mixed; boundary="ktXVOo4LUsbCwBkAI9IPlhh5iLgCJTaPb"; protected-headers="v1" From: Mathieu Arnold To: Raphael Kubo da Costa Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <683d02ff-4117-508f-8a66-3f1712043009@FreeBSD.org> Subject: Re: svn commit: r426759 - in head/databases/xapian-core: . files References: <201611212126.uALLQxT0063108@repo.freebsd.org> <86oa17lt6j.fsf@FreeBSD.org> In-Reply-To: <86oa17lt6j.fsf@FreeBSD.org> --ktXVOo4LUsbCwBkAI9IPlhh5iLgCJTaPb Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Le 22/11/2016 =C3=A0 11:12, Raphael Kubo da Costa a =C3=A9crit : > Mathieu Arnold writes: > >> Le 21/11/2016 =C3=A0 22:26, Raphael Kubo da Costa a =C3=A9crit : >> >>> SOCK_CLOEXEC was introduced in FreeBSD 10, so define it to 0 on Fre= eBSD 9 (the >>> code already handles this case). Xapian 1.4 has a safesyssocket.h t= hat does the >>> same thing. >> But FreeBSD 10 is not 1000000. In that case, according to >> sys/sys/socket.h's log, it was added in r248534, the closest version i= s >> 1000031. > I tried looking for a specific entry mentioning SOCK_CLOEXEC in the > porter's handbook and decided to go with 1000000 after not finding > anything. > > I'm fine with adjusting the check, but given 1000031 predates even the > branching of FreeBSD 10 and the minimum 10.x version we currently > support is 10.1, does it make sense to do that? 1000000 is wrong because SOCK_CLOEXEC was added between 1000030 and 1000031. So the right OSVERSION to use is 1000031. --=20 Mathieu Arnold --ktXVOo4LUsbCwBkAI9IPlhh5iLgCJTaPb-- --i2nONGUpsM4Rp4ef8PsBnQnuLOitVSAFg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJYNDL6XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IjU4P/jAfHaM8kFKKhNpODUX9JsYN fPb0hqDoNGSKTrwqFs1uE2gYmV1uiCjniVBIT3AOdpTllU1PFgtnF32uEec8rmib Z+jq18p2QAZS6TF+3zItLEkoCb7IdpscxHSbkMFpqTjxd065rIPweGwratzCyxvW XuXqQdRjKkr/ExdlGCogu8cmO1tlwyRjt0J9tS6z+vQfIB1JXlnh/428SR6KbSdV ZT15+/a1boxKsq4VZ6w3hT1qh3ya10d+DcXnPXW24OIi3l3cV3cjm9L10wd1rxZs mh+sf/aZdyoVv/zvqya9nTqdzS9G/1c/Srlx5+OGX+kVXdHpc4A6o1G6Xv+wMnSU PnMv1FSAcNj2dhz46UjRSXAZ2PVxB6w1gYHag69KmC4KarxDiMMB4CPH03xk1g3a 0Iq+yHOkj8snRmFlEgPHzM2C+mYuQPzqZHPAMAVW5CD2wNOtDg3RJijyvBoB6k0A 7qmE596RczYYjK6eBLYGxaqtJBvzfq9Kcu3IJaSmVXTO2oZtvkcney/JOHx9kYg1 cBhxpNl+MhmagHFSs9lgTFXpBYkHTbohObbBQI01arx6REhC/YPsZRWUfspG/UnE 51sM6fgKTRQ0Z/8S/6w1BZdqWYlkp4SA/8Vb1V1l56c0riO4TxD2EO3bTjrAduhT C3a7fwcDEkkLokfWVcL1 =we41 -----END PGP SIGNATURE----- --i2nONGUpsM4Rp4ef8PsBnQnuLOitVSAFg--