From nobody Sat Jul 1 19:43:33 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QtjKw0JpQz4jtHH for ; Sat, 1 Jul 2023 19:43:48 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QtjKv6MPfz3DRr for ; Sat, 1 Jul 2023 19:43:47 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3142a9ff6d8so1011578f8f.3 for ; Sat, 01 Jul 2023 12:43:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688240626; x=1690832626; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iK15JT/WGb4JCb3/+Fp1zNnXJ6h8q517LJdmaDZanaA=; b=l1QpvCwBMdYUveK7kjs8WeH+p0bZn+l9OOluas50Z787j+Rz84vE9/fjYilFbf/Vf0 8En9YV+/egMfVK0xG7UAyBRmMKrSwb6/x5uXw75ZI2gWOJ3pCLLc57umG7U3Mt25u+dY xvBowbBERb4raLXljEiTJ7eHne1p2FFko4o4FixXUGxC7KkCqCu8u/aCvI45ratyOu3+ ktqObD5xQ4v6LWvcN/ZrHCQwUf4wfAAjTAB+WvrctRtwcSSdVvaO3J6d63kpZc9icrui KUunm6JT+CBi6t4d2ZotQPUxmb5bn+wWW9YtR+pu8vStZLL97Bu9a5hb8+LIYDzPiS6g lTiA== X-Gm-Message-State: ABy/qLaXEoLuCyne2Urg+g7JH7SPzB1R5SisQP/E5ZPdWTUn3tTVj29k +xhLV9jNCEzR+MzTl1M/QkYkSw== X-Google-Smtp-Source: APBJJlHj+Vf8naupj8SND45xlyCnhRc31N7y59Vt8NIAhUlOmwBHEnnbpWQQhf1Iaj6Gr0KT2SmNag== X-Received: by 2002:adf:e510:0:b0:314:2881:a331 with SMTP id j16-20020adfe510000000b003142881a331mr2518127wrm.40.1688240626130; Sat, 01 Jul 2023 12:43:46 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.246]) by smtp.gmail.com with ESMTPSA id c8-20020adfed88000000b0031433443265sm28657wro.53.2023.07.01.12.43.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 01 Jul 2023 12:43:44 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Subject: Re: git: da3096a92d2c - main - rdrand_rng: Build with -fPIC on i386 when using GCC. From: Jessica Clarke In-Reply-To: <202307011923.361JNMtJ070354@gitrepo.freebsd.org> Date: Sat, 1 Jul 2023 20:43:33 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <43225A5D-CBC7-4F1E-9B28-78A5A703FB56@freebsd.org> References: <202307011923.361JNMtJ070354@gitrepo.freebsd.org> To: John Baldwin X-Mailer: Apple Mail (2.3731.600.7) X-Rspamd-Queue-Id: 4QtjKv6MPfz3DRr X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 1 Jul 2023, at 20:23, John Baldwin wrote: >=20 > The branch main has been updated by jhb: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dda3096a92d2c1c06b25613444d9b3694= 75d50321 >=20 > commit da3096a92d2c1c06b25613444d9b369475d50321 > Author: John Baldwin > AuthorDate: 2023-07-01 19:23:00 +0000 > Commit: John Baldwin > CommitDate: 2023-07-01 19:23:00 +0000 >=20 > rdrand_rng: Build with -fPIC on i386 when using GCC. >=20 > ld.bfd requires an R_386_PLT32 relocation for calls to ifuncs > rather than R_386_PC32. (lld permits R_386_PC32.) That=E2=80=99s odd and doesn=E2=80=99t quite seem a sufficient = explanation on its own? PDEs can have IFUNCs just fine today, so why is it different for kernel modules here? Jess > Reviewed by: kib > Differential Revision: https://reviews.freebsd.org/D40811 > --- > sys/modules/rdrand_rng/Makefile | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/sys/modules/rdrand_rng/Makefile = b/sys/modules/rdrand_rng/Makefile > index 7f14c080a260..3fdecd64f78f 100644 > --- a/sys/modules/rdrand_rng/Makefile > +++ b/sys/modules/rdrand_rng/Makefile > @@ -8,4 +8,9 @@ SRCS+=3D bus_if.h device_if.h >=20 > CFLAGS+=3D -I${SRCTOP}/sys >=20 > +# ld.bfd doesn't support ifuncs invoked non-PIC > +.if ${MACHINE_CPUARCH} =3D=3D "i386" > +CFLAGS.gcc=3D -fPIC > +.endif > + > .include