From owner-dev-commits-src-all@freebsd.org Thu Jan 28 17:46:53 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A25DC4E4F0F; Thu, 28 Jan 2021 17:46:53 +0000 (UTC) (envelope-from arichardson.kde@gmail.com) Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DRSb144j5z4RbM; Thu, 28 Jan 2021 17:46:53 +0000 (UTC) (envelope-from arichardson.kde@gmail.com) Received: by mail-ej1-f51.google.com with SMTP id bl23so9064900ejb.5; Thu, 28 Jan 2021 09:46:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pft0Nd6zH0A5xIhZFdxbUamrFXUws+kz0nzElSewkBA=; b=LeM2FLkC0mYTg1TmjAYnVI+WXsMpjWCR7FTi1cYmxG+p/YV3hvZwCvsPbW/bCo2sDV JGepFsC9ftHutdemmtJBqZfi6oEhhK3q02wVpuHsMC6HN4o6ZXelCu4iOQ6D3GdFRnGV WAcGLDiDKzSy7Nt6rF5s0KP7SyBCKAMCYNFfr1Ai4GLxUE1jhITd7j6hp3Fk3cGiDMIZ 6sAeO9sgzRQ+R6dcpIEtYDXVr6OiT+GdvCyQ6fdofutTuHnChU/CG/REr531eRuOcdn9 BeCEubC4XAPZ4Ebi1i0uvUz2tv8bQ5XXjVLK1cdT7+ihhidL5/IaXeeIaXBC+acyOPjX NStg== X-Gm-Message-State: AOAM531QBRr9gEisY/wvnRzrBHVeyh/8yoackkRyx56qCDjnBoUtqwhO 6j1hhgD4DGTqJM1kauuYjz3g9BfPU1xWTg== X-Google-Smtp-Source: ABdhPJxRkAlq/GZfXh+odAuli5Ej+ik3FjBXb42uqwj+4SzRL7+mMCKRP0oAL3d5BuvMtVj2CLYXCg== X-Received: by 2002:a17:907:a077:: with SMTP id ia23mr518631ejc.434.1611856012018; Thu, 28 Jan 2021 09:46:52 -0800 (PST) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com. [209.85.128.43]) by smtp.gmail.com with ESMTPSA id pg19sm2716497ejb.0.2021.01.28.09.46.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jan 2021 09:46:51 -0800 (PST) Received: by mail-wm1-f43.google.com with SMTP id m2so5005571wmm.1; Thu, 28 Jan 2021 09:46:51 -0800 (PST) X-Received: by 2002:a1c:2c0b:: with SMTP id s11mr358781wms.13.1611856011426; Thu, 28 Jan 2021 09:46:51 -0800 (PST) MIME-Version: 1.0 References: <202101281739.10SHdh37056796@gitrepo.freebsd.org> <6B60F7D5-AD3E-459E-801A-65234A689A01@freebsd.org> In-Reply-To: <6B60F7D5-AD3E-459E-801A-65234A689A01@freebsd.org> From: Alexander Richardson Date: Thu, 28 Jan 2021 17:46:39 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 83ff5d5d98cb - main - Un-XFAIL two tests with Clang > 10 To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4DRSb144j5z4RbM X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2021 17:46:53 -0000 On Thu, 28 Jan 2021 at 17:42, Jessica Clarke wrote: > > Is the commit message or the diff wrong? Both use strict inequalities. > > Jess Sorry the commit message should be >= 10. Alex > > On 28 Jan 2021, at 17:39, Alex Richardson wrote: > > > > The branch main has been updated by arichardson: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=83ff5d5d98cbcf9b66dccd70022358aec8918a14 > > > > commit 83ff5d5d98cbcf9b66dccd70022358aec8918a14 > > Author: Alex Richardson > > AuthorDate: 2021-01-28 17:17:49 +0000 > > Commit: Alex Richardson > > CommitDate: 2021-01-28 17:24:24 +0000 > > > > Un-XFAIL two tests with Clang > 10 > > > > SVN r343917 fixed this for in-tree clang, but when building with a newer > > out-of-tree clang the test was still marked as XFAIL. > > > > Reviewed By: dim > > Differential Revision: https://reviews.freebsd.org/D28390 > > --- > > contrib/netbsd-tests/lib/libm/t_cbrt.c | 4 ++-- > > lib/msun/tests/trig_test.c | 2 +- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/contrib/netbsd-tests/lib/libm/t_cbrt.c b/contrib/netbsd-tests/lib/libm/t_cbrt.c > > index d2cdd47a5beb..08e9faeb145c 100644 > > --- a/contrib/netbsd-tests/lib/libm/t_cbrt.c > > +++ b/contrib/netbsd-tests/lib/libm/t_cbrt.c > > @@ -269,8 +269,8 @@ ATF_TC_BODY(cbrtl_powl, tc) > > size_t i; > > > > #if defined(__amd64__) && defined(__clang__) && __clang_major__ >= 7 && \ > > - __FreeBSD_cc_version < 1300002 > > - atf_tc_expect_fail("test fails with clang 7+ - bug 234040"); > > + __clang_major__ < 10 && __FreeBSD_cc_version < 1300002 > > + atf_tc_expect_fail("test fails with clang 7-9 - bug 234040"); > > #endif > > > > for (i = 0; i < __arraycount(x); i++) { > > diff --git a/lib/msun/tests/trig_test.c b/lib/msun/tests/trig_test.c > > index 483a5e187d50..ba1975721d3f 100644 > > --- a/lib/msun/tests/trig_test.c > > +++ b/lib/msun/tests/trig_test.c > > @@ -161,7 +161,7 @@ ATF_TC_BODY(reduction, tc) > > unsigned i; > > > > #if defined(__amd64__) && defined(__clang__) && __clang_major__ >= 7 && \ > > - __FreeBSD_cc_version < 1300002 > > + __clang_major__ < 10 && __FreeBSD_cc_version < 1300002 > > atf_tc_expect_fail("test fails with clang 7+ - bug 234040"); > > #endif > > >