From owner-svn-src-head@FreeBSD.ORG Sat Jun 29 16:36:14 2013 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 6F45931E; Sat, 29 Jun 2013 16:36:14 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from monday.kientzle.com (99-115-135-74.uvs.sntcca.sbcglobal.net [99.115.135.74]) by mx1.freebsd.org (Postfix) with ESMTP id 31B381C96; Sat, 29 Jun 2013 16:36:13 +0000 (UTC) Received: (from root@localhost) by monday.kientzle.com (8.14.4/8.14.4) id r5TGaDSB058818; Sat, 29 Jun 2013 16:36:13 GMT (envelope-from kientzle@FreeBSD.org) Received: from [192.168.2.123] (CiscoE3000 [192.168.1.65]) by kientzle.com with SMTP id qzycpfrm7wr92sbmxujztkm2a2; Sat, 29 Jun 2013 16:36:13 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Subject: Re: svn commit: r252376 - head/lib/libutil Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: multipart/signed; boundary="Apple-Mail=_538AA7F9-4413-41BA-89F4-BBD9B2A68BE2"; protocol="application/pgp-signature"; micalg=pgp-sha1 From: Tim Kientzle In-Reply-To: <20130629161914.GD91021@kib.kiev.ua> Date: Sat, 29 Jun 2013 09:36:10 -0700 Message-Id: References: <201306291552.r5TFqnLV022460@svn.freebsd.org> <20130629161914.GD91021@kib.kiev.ua> To: Konstantin Belousov X-Mailer: Apple Mail (2.1283) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Jun 2013 16:36:14 -0000 --Apple-Mail=_538AA7F9-4413-41BA-89F4-BBD9B2A68BE2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On Jun 29, 2013, at 9:19 AM, Konstantin Belousov wrote: > On Sat, Jun 29, 2013 at 03:52:49PM +0000, Tim Kientzle wrote: >> Author: kientzle >> Date: Sat Jun 29 15:52:48 2013 >> New Revision: 252376 >> URL: http://svnweb.freebsd.org/changeset/base/252376 >>=20 >> Log: >> Fix -Wunsequenced warning > What is this ? =46rom the name of the warning, it sounds as if the = problem > is in the lack of sequence point between two modifications of the same > variable in the expression ? >=20 > But, there function' argument evaluation and function call are = separated > by seq point, AFAIR. Could you, please, clarify ? I think you're right about that, though I'd have to look at the spec to be sure. Not sure why clang would report this as a -Wunsequenced warning. The implied store here is certainly redundant, though. Tim >> Submitted by: dt71@gmx.com >>=20 >> Modified: >> head/lib/libutil/login_times.c >>=20 >> Modified: head/lib/libutil/login_times.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/lib/libutil/login_times.c Sat Jun 29 15:51:27 2013 = (r252375) >> +++ head/lib/libutil/login_times.c Sat Jun 29 15:52:48 2013 = (r252376) >> @@ -96,7 +96,7 @@ parse_lt(const char *str) >> else >> m.lt_start =3D 0; >> if (*p =3D=3D '-') >> - p =3D parse_time(++p, &m.lt_end); >> + p =3D parse_time(p + 1, &m.lt_end); >> else >> m.lt_end =3D 1440; >>=20 >=20 --Apple-Mail=_538AA7F9-4413-41BA-89F4-BBD9B2A68BE2 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) iQEcBAEBAgAGBQJRzwz7AAoJEGMNyGo0rfFB35QH/1wG9cBd+d/SMmk8clA9uZPF 4AQykeKwhjptBt37tDGq6P1I2RYhInGdBJO4LEXAvhCJSO24yzXpDIhg9CF+71+T 213/i5hkvHYjCsQlyeGoJkXOo79FkjFz7D7sgHUXxYta/Hnx4DizSORzv5aW7hHP KVLGZbCDE1ifXEl2oO4AnuZjB3Ed0iHxSKOMpE37SnghZhz/BUcy77WsEB0Eoo6Y pbvHYeGxYNBzmYf/tvyyNQZ9Ua0lmCqhqi0xazJJnV1KsxUEzG5KST3EHD2GBIb2 g6WCcjVkA7bskegUFtoAoKKWxl+zqtXckHlG1IkpkMQHMOVWF/18jUDwdDsY1l8= =d9g7 -----END PGP SIGNATURE----- --Apple-Mail=_538AA7F9-4413-41BA-89F4-BBD9B2A68BE2--