From owner-svn-src-head@freebsd.org Mon Nov 27 21:41:45 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6BCD3DEA468; Mon, 27 Nov 2017 21:41:45 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk0-x244.google.com (mail-qk0-x244.google.com [IPv6:2607:f8b0:400d:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 223B965E4F; Mon, 27 Nov 2017 21:41:45 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qk0-x244.google.com with SMTP id d125so34472002qkc.12; Mon, 27 Nov 2017 13:41:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jwQN6L2YBx+q5tlF8a7AEIs5wpCi06TS6WxV0PcVTng=; b=GyZdvKdEcma9D21M29yq29nt+MSX7Or/hbIl5YdxCT/rM/6d9L2Dm/L5CvRSzIPW+N rAZRx2oMSQDzp/5IQ0pEAC1jnriZIQlc5qI99acwxRAqrDMhHhbLl7MylpWgLI4PWmA+ V+p59F+8Z2FeVBsF0OroyRdRNziRQXA8H/ys+7xFIs6Ts/OtzxcmVfwt3ezlzIoK/tJ8 FLb/jBvOYrR5V6froXPPQw9Ny27wQ3YAB21/R2FuR5NDQxIC5VA+5bbwtReneqevTU6d d4LPjeGxcYzPR94umlLbnLBr5r4ophezCS+8j7WMxSsMw5gL/QGHvx9IC+pUZ0vfCicR S/gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=jwQN6L2YBx+q5tlF8a7AEIs5wpCi06TS6WxV0PcVTng=; b=GkeYFhUmYq7tIyy9TwnmUIjXs5SS2aV8o2CZSUtJwcIVAf71jTO2XuvsPTkBSRqdrm 3yDNqPWK3D6WTOzXTPjqyiugn7o/bpQXa84TLuR8z8PvxXOv6hEZoKjWN4BWntziuvX/ ugw9T4n8bZsN51zpHVzvmXlH/S52Hbv2kfSmTSfxUU26Osx8TUZ2StsWZ7YWsJjIhlxB mMMponZUbl0X/nyKpQ2TeV/ZpgPSdlVnaEFOjH+SuxAjBKxSIcgK03ceVo8ujw/fDKfT h3JP4naL6YlucbhlBE7H+UJdgRCBVsmKkc95KZy0iQh53HNvMjU9Oz4qeutC7a3nB/v4 wtfw== X-Gm-Message-State: AJaThX7nD31rrju38MRK5l8eYbIWs9SNfiw9QGTrs3KfZbtMsbX21i5m BVdm5q5onDJkKQRVsqRjr9Z2tA== X-Google-Smtp-Source: AGs4zMbTAOITcsyj+pEo8d8fCD+0pWcZ0MiWSYVVz5MIVwWAMtcF9Ztg+oiCfMhDjiVnC24XXgoEjg== X-Received: by 10.55.65.70 with SMTP id o67mr25048525qka.48.1511818903917; Mon, 27 Nov 2017 13:41:43 -0800 (PST) Received: from raichu (toroon0560w-lp140-01-69-159-38-22.dsl.bell.ca. [69.159.38.22]) by smtp.gmail.com with ESMTPSA id q12sm21036542qtk.32.2017.11.27.13.41.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Nov 2017 13:41:42 -0800 (PST) Sender: Mark Johnston Date: Mon, 27 Nov 2017 16:41:40 -0500 From: Mark Johnston To: John Baldwin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r326286 - head/sys/cddl/dev/dtrace Message-ID: <20171127214140.GB75832@raichu> References: <201711271842.vARIgNCk007369@repo.freebsd.org> <2717040.9stBD4iAp4@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2717040.9stBD4iAp4@ralph.baldwin.cx> User-Agent: Mutt/1.9.1 (2017-09-22) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Nov 2017 21:41:45 -0000 On Mon, Nov 27, 2017 at 11:28:07AM -0800, John Baldwin wrote: > On Monday, November 27, 2017 06:42:23 PM Mark Johnston wrote: > > Author: markj > > Date: Mon Nov 27 18:42:23 2017 > > New Revision: 326286 > > URL: https://svnweb.freebsd.org/changeset/base/326286 > > > > Log: > > Don't use pcpu_find() to determine if a CPU ID is valid. > > > > This addresses assertion failures after r326218. > > I'd perhaps rather revert the assertion as per my other mail? I considered waiting for a resolution of that thread, but it seems to me that using CPU_FOREACH()/CPU_ABSENT() is more idiomatic anyway? We already use CPU_FOREACH() in a few places in dtrace.c, and dtrace_ioctl.c is meant to be a fork of the ioctl handler from illumos, i.e., we shouldn't make much effort to avoid diverging from upstream.