From owner-svn-src-all@FreeBSD.ORG Wed Apr 7 08:00:27 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7949B106566C; Wed, 7 Apr 2010 08:00:27 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 03CC48FC17; Wed, 7 Apr 2010 08:00:26 +0000 (UTC) Received: from outgoing.leidinger.net (pD9E2D3E3.dip.t-dialin.net [217.226.211.227]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 2BD468442CF; Wed, 7 Apr 2010 10:00:21 +0200 (CEST) Received: from webmail.leidinger.net (webmail.leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 6E3F7504E; Wed, 7 Apr 2010 10:00:16 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.14.3/8.13.8/Submit) id o3780Geb058012; Wed, 7 Apr 2010 10:00:16 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Wed, 07 Apr 2010 10:00:15 +0200 Message-ID: <20100407100015.117169nw2iu6xp4w@webmail.leidinger.net> Date: Wed, 07 Apr 2010 10:00:15 +0200 From: Alexander Leidinger To: "M. Warner Losh" References: <20100405143123.14716pelm4tos2kg@webmail.leidinger.net> <20100405133505.GK2415@deviant.kiev.zoral.com.ua> <20100405181450.13494itjj2ehj5og@webmail.leidinger.net> <20100406.105417.934842008305588111.imp@bsdimp.com> In-Reply-To: <20100406.105417.934842008305588111.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.4) X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: 2BD468442CF.62636 X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-0.763, required 6, autolearn=disabled, ALL_TRUSTED -1.44, J_CHICKENPOX_83 0.60, TW_SV 0.08) X-EBL-MailScanner-From: netchild@freebsd.org X-EBL-MailScanner-Watermark: 1271232022.03556@SbFFZiGcYqDht0wdGx+Mow X-EBL-Spam-Status: No Cc: kostikbel@gmail.com, svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r206082 - in head: . share/man/man7 share/mk sys/conf X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Apr 2010 08:00:27 -0000 Quoting "M. Warner Losh" (from Tue, 06 Apr 2010 10:54:17 -0600 (MDT)): > In message: <20100405181450.13494itjj2ehj5og@webmail.leidinger.net> > Alexander Leidinger writes: > : Warner, do you mind if I back-out r206082 and change the place where > : NORMAL_CTFCONVERT is used instead (fist I have to search for it > : again... not today)? It would make it consistent with all other places > : (SYSTEM_CTFCONVERT and the plain test and use of CTFxxx). > > Go ahead. I just did the fast and dirty fix. I though it was > consistent with how other things were done, but if not, feel free to > correct it. Also, see bde's commentary :) I can not find it, can you please forward it to me? Here is what I have ATM (copy&paste, so tabs are probably mangled): ---snip--- Index: usr.sbin/config/mkmakefile.c =================================================================== --- usr.sbin/config/mkmakefile.c (revision 206031) +++ usr.sbin/config/mkmakefile.c (working copy) @@ -741,7 +741,7 @@ printf("config: don't know rules for %s\n", np); break; } - snprintf(cmd, sizeof(cmd), "${%s_%c%s}\n.if defined(NORMAL_CTFCONVERT) && !empty(NORMAL_CTFCONVERT)\n\t${NORMAL_CTFCONVERT}\n.endif", ftype, + snprintf(cmd, sizeof(cmd), "${%s_%c%s}\n\t@${NORMAL_CTFCONVERT}", ftype, toupper(och), ftp->f_flags & NOWERROR ? "_NOWERROR" : ""); compilewith = cmd; Index: sys/conf/kern.pre.mk =================================================================== --- sys/conf/kern.pre.mk (revision 206248) +++ sys/conf/kern.pre.mk (working copy) @@ -128,7 +128,7 @@ NORMAL_M= ${AWK} -f $S/tools/makeobjops.awk ${.IMPSRC} -c ; \ ${CC} -c ${CFLAGS} ${WERROR} ${PROF} ${.PREFIX}.c -NORMAL_CTFCONVERT= @[ -z "${CTFCONVERT}" -o -n "${NO_CTF}" ] || ${CTFCONVERT} ${CTFFLAGS} ${.TARGET} +NORMAL_CTFCONVERT= [ -z "${CTFCONVERT}" -o -n "${NO_CTF}" ] || ${CTFCONVERT} ${CTFFLAGS} ${.TARGET} NORMAL_LINT= ${LINT} ${LINTFLAGS} ${CFLAGS:M-[DIU]*} ${.IMPSRC} ---snip--- Bye, Alexander. -- http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 Look before you leap. -- Samuel Butler