From owner-cvs-all@FreeBSD.ORG Wed Jun 21 18:14:03 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 436DF16A49A; Wed, 21 Jun 2006 18:14:03 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3764D43D46; Wed, 21 Jun 2006 18:14:02 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k5LIDUKc040406; Wed, 21 Jun 2006 14:13:57 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Tom Rhodes Date: Wed, 21 Jun 2006 13:06:35 -0400 User-Agent: KMail/1.9.1 References: <200606201516.39121.jhb@freebsd.org> <20060620.155140.-1816810644.imp@bsdimp.com> <20060620193458.42040d97.trhodes@FreeBSD.org> In-Reply-To: <20060620193458.42040d97.trhodes@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200606211306.36770.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 21 Jun 2006 14:13:58 -0400 (EDT) X-Virus-Scanned: ClamAV 0.87.1/1559/Wed Jun 21 10:23:13 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: cvs-src@freebsd.org, cvs-all@freebsd.org, src-committers@freebsd.org, obrien@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src Makefile README X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2006 18:14:03 -0000 On Tuesday 20 June 2006 19:34, Tom Rhodes wrote: > On Tue, 20 Jun 2006 15:51:40 -0600 (MDT) > "M. Warner Losh" wrote: > > > In message: <200606201714.10331.jhb@freebsd.org> > > John Baldwin writes: > > : On Tuesday 20 June 2006 16:41, M. Warner Losh wrote: > > : > In message: <200606201516.39121.jhb@freebsd.org> > > : > John Baldwin writes: > > : > : On Tuesday 20 June 2006 14:53, David O'Brien wrote: > > : > : > On Wed, Jun 07, 2006 at 07:43:00PM -0400, Tom Rhodes wrote: > > : > : > > Personally, I was debating on just removing most of the > > : > : > > world target with just a message: > > : > : > > > > : > : > > "The world target has been replaced with the buildworld target." > > : > : > > > : > : > No! > > : > : > > > : > : > 'make world' is still my normal building process. Why force > > : > : > "make buildworld && make installworld"?? > > : > : > > > : > : > I don't care how undocumented it is, or obfusacted > > : > : > 'HISTORICAL_MAKE_WORLD' is; but please leave them alone! > > : > : > > > : > : > thanks for your attention. > > : > : > > : > : You can already get that via 'make DESTDIR=/ world' you know. :) And > > : that's > > : > : shorter to type. > > : > > > : > It has been pointed out to me that you can't put DESTDIR=/ in your > > : > /etc/make.conf file; however, you can put HISTORICAL_MAKE_WORLD=y in > > : > there. > > : > > : Fair enough. How about just making it undocumented again then? :) > > > > Works for me. > > Doesn't work here. Sorry. It's fine that the options stay > there, but personally, I can understand why some users would > be pissed about this being undocumented. If I started a build > and expected it to run all night, seen it bombed in the > morning, well ... Yea, I'd be pissed too. :) The nature of the compromise over 'make world' was that rather than removing the knob we'd leave it undocumented so that new users aren't tempted to use it, but instead will revert to using buildworld/installworld as they ought to if they get a failure running 'make world'. If we are going to document the knob and thus make it user-supported, we might as well remove it and just make 'make world' user-supported. -- John Baldwin