From owner-freebsd-chromium@FreeBSD.ORG Wed Aug 27 00:50:01 2014 Return-Path: Delivered-To: freebsd-chromium@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2D656605; Wed, 27 Aug 2014 00:50:01 +0000 (UTC) Received: from mail-wg0-x232.google.com (mail-wg0-x232.google.com [IPv6:2a00:1450:400c:c00::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7C9CF3803; Wed, 27 Aug 2014 00:50:00 +0000 (UTC) Received: by mail-wg0-f50.google.com with SMTP id n12so15453242wgh.9 for ; Tue, 26 Aug 2014 17:49:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=68MHkuMK025MtAhq9Ncd907yppifFiBHc60vzyfZbmY=; b=lJVxixnch5UZB3zccyCuW02POob+sOmJ6lllEoUdeAWbxFwyR+rniQNZiWXt0Witea JRrLm6XPkwu5ru3sYiMJi40oLW5VmWdTf245EhS+m6hu7R0ToKPpD7G6KQdBAnXnlbj1 sQBGypZaF7JYCNtdCerMm7l0836EGv4ZkFVyY9/ciSZ9gSLfPVIkG+RSHUWGBYP6lAYM NLRzmMlHoeMcxu1jc6Ab21++iDgiTUzQ4IvO3MSv9fjPonU3rQGceZPqb84BnCu6MmbA L/D+W8Huduxer2sUshiI+ljuW3fTfhg2V38mDmcO/jp3QipA3DtNwAAmbkXUx/1i84JZ WjWA== X-Received: by 10.194.184.101 with SMTP id et5mr33497298wjc.14.1409100598495; Tue, 26 Aug 2014 17:49:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.121.37 with HTTP; Tue, 26 Aug 2014 17:49:37 -0700 (PDT) In-Reply-To: <20140826192509.906c9f1ceb167d7b2a145f59@fbsd.es> References: <20140826153613.a1203a3d3d3e3ef56691b1fb@fbsd.es> <20140826192509.906c9f1ceb167d7b2a145f59@fbsd.es> From: Miguel Clara Date: Wed, 27 Aug 2014 01:49:37 +0100 Message-ID: Subject: Re: chromium 37 up for testing (and polishing) To: Carlos Jacobo Puga Medina Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: chromium-list freebsd X-BeenThere: freebsd-chromium@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: FreeBSD-specific Chromium issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Aug 2014 00:50:01 -0000 Thanks Carlos and Ren=C3=A9 for you're hard work! Are this changes on the port already? I was trying to build the port on poudriere and it fails, so I wonder if this is related to the patches. poudriere 10-amd64 jail tail -30 /usr/local/poudriere/data/logs/bulk/10x64-default/latest/logs/chromium-37.0= .2062.94.log In file included from ../../ui/gl/gl_bindings.h:230: gen/ui/gl/gl_bindings_autogen_gl.h:70:81: error: unknown type name 'GLeglImageOES' typedef void (GL_BINDING_CALL *glEGLImageTargetTexture2DOESProc)(GLenum target, GLeglImageOES image); ^ gen/ui/gl/gl_bindings_autogen_gl.h:71:91: error: unknown type name 'GLeglImageOES' typedef void (GL_BINDING_CALL *glEGLImageTargetRenderbufferStorageOESProc)(GLenum target, GLeglImageOES image); ^ gen/ui/gl/gl_bindings_autogen_gl.h:543:62: error: unknown type name 'GLeglImageOES' virtual void glEGLImageTargetTexture2DOESFn(GLenum target, GLeglImageOES image) =3D 0; ^ gen/ui/gl/gl_bindings_autogen_gl.h:544:72: error: unknown type name 'GLeglImageOES' virtual void glEGLImageTargetRenderbufferStorageOESFn(GLenum target, GLeglImageOES image) =3D 0; ^ In file included from ../../gpu/command_buffer/service/buffer_manager.cc:10= : In file included from ../../gpu/command_buffer/service/context_state.h:16: ../../gpu/command_buffer/service/vertex_attrib_manager.h:204:29: error: use of undeclared identifier 'GL_FIXED' if (attrib->type() =3D=3D GL_FIXED) { ^ ../../gpu/command_buffer/service/vertex_attrib_manager.h:207:19: error: use of undeclared identifier 'GL_FIXED' if (type =3D=3D GL_FIXED) { ^ 6 errors generated. ninja: build stopped: subcommand failed. *** Error code 1 Stop. Melhores Cumprimentos // Best Regards ----------------------------------------------- *Miguel Clara* *IT - Sys Admin & Developer* *E-mail: *miguelmclara@gmail.com www.linkedin.com/in/miguelmclara/ On Tue, Aug 26, 2014 at 6:25 PM, Carlos Jacobo Puga Medina wrote: > On Tue, 26 Aug 2014 18:39:10 +0200 > Ren=C3=A9 Ladan wrote: > > > > 2014-08-26 15:36 GMT+02:00 Carlos Jacobo Puga Medina : > > > > > > Finally, I installed chromium 37.0.2062.94 on 11-CURRENT/i386. I buil= t > it > > > with clang 3.4.1. I need to check further before have a respetable > opinion, > > > but for now it looks pretty cool. > > > > > > The following patches fix chromium build with Clang > > > > > > I still don't get why they are needed (strictly speaking), chromium > builds > > fine in my 11-i386 vm having only the dependencies of chromium (and pkg > and > > panicmail) installed. > > > > But if people insist I'll just add them. > > Do it if you consider it necessary, but I needed these patches to fix > typedefs errors (a bunch of course). Also, it solved the same problem in > chromium-36.0.1985.143. > > > > > Rene > > > > > > > --- ./gpu/command_buffer/common/gles2_cmd_format.h.orig 2014-08-20 > > > 21:02:37.000000000 +0200 > > > +++ ./gpu/command_buffer/common/gles2_cmd_format.h 2014-08-25 > > > 23:47:01.000000000 +0200 > > > @@ -39,8 +39,8 @@ > > > typedef double GLdouble; > > > typedef double GLclampd; > > > typedef void GLvoid; > > > -typedef khronos_intptr_t GLintptr; > > > -typedef khronos_ssize_t GLsizeiptr; > > > +typedef ptrdiff_t GLintptr; > > > +typedef ptrdiff_t GLsizeiptr; > > > > > > namespace gpu { > > > namespace gles2 { > > > > > > --- ./gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc.orig > 2014-08-24 > > > 12:26:40.000000000 +0200 > > > +++ ./gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc 2014-08-24 > > > 12:33:01.000000000 +0200 > > > @@ -31,8 +31,8 @@ > > > functions->fBindVertexArray =3D glBindVertexArrayOES; > > > functions->fBlendColor =3D glBlendColor; > > > functions->fBlendFunc =3D glBlendFunc; > > > - functions->fBufferData =3D glBufferData; > > > - functions->fBufferSubData =3D glBufferSubData; > > > + functions->fBufferData =3D (GrGLBufferDataProc)glBufferData; > > > + functions->fBufferSubData =3D (GrGLBufferSubDataProc)glBufferSubDa= ta; > > > functions->fClear =3D glClear; > > > functions->fClearColor =3D glClearColor; > > > functions->fClearStencil =3D glClearStencil; > > > @@ -74,7 +74,7 @@ > > > functions->fInsertEventMarker =3D glInsertEventMarkerEXT; > > > functions->fLineWidth =3D glLineWidth; > > > functions->fLinkProgram =3D glLinkProgram; > > > - functions->fMapBufferSubData =3D glMapBufferSubDataCHROMIUM; > > > + functions->fMapBufferSubData =3D > > > (GrGLMapBufferSubDataProc)glMapBufferSubDataCHROMIUM; > > > functions->fMapTexSubImage2D =3D glMapTexSubImage2DCHROMIUM; > > > functions->fPixelStorei =3D glPixelStorei; > > > functions->fPopGroupMarker =3D glPopGroupMarkerEXT; > > > > > > --- ./ppapi/c/ppb_opengles2.h.orig 2014-08-25 23:42:52.000000000 > +0200 > > > +++ ./ppapi/c/ppb_opengles2.h 2014-08-25 23:44:21.000000000 +0200 > > > @@ -34,8 +34,8 @@ > > > typedef long long int GLintptr; > > > typedef long long int GLsizeiptr; > > > #else > > > -typedef long int GLintptr; > > > -typedef long int GLsizeiptr; > > > +typedef __ptrdiff_t GLintptr; > > > +typedef __ptrdiff_t GLsizeiptr; > > > #endif // _WIN64 > > > #endif // __gl2_h_ > > > > > > --- ./third_party/khronos/GLES2/gl2.h.orig 2014-08-20 > > > 21:03:05.000000000 +0200 > > > +++ ./third_party/khronos/GLES2/gl2.h 2014-08-25 23:48:36.000000000 > +0200 > > > @@ -38,6 +38,7 @@ > > > > > > #include > > > #include > > > +#include > > > > > > /* Generated on date 20131202 */ > > > > > > @@ -67,8 +68,8 @@ > > > typedef unsigned int GLuint; > > > typedef char GLchar; > > > typedef khronos_float_t GLfloat; > > > -typedef khronos_ssize_t GLsizeiptr; > > > -typedef khronos_intptr_t GLintptr; > > > +typedef ptrdiff_t GLintptr; > > > +typedef ptrdiff_t GLsizeiptr; > > > typedef unsigned int GLbitfield; > > > typedef int GLint; > > > typedef unsigned char GLboolean; > > > > > > --- ./third_party/mesa/src/include/GLES2/gl2.h.orig 2014-08-20 > > > 21:03:54.000000000 +0200 > > > +++ ./third_party/mesa/src/include/GLES2/gl2.h 2014-08-25 > > > 23:50:18.000000000 +0200 > > > @@ -4,6 +4,7 @@ > > > /* $Revision: 10602 $ on $Date:: 2010-03-04 22:35:34 -0800 #$ */ > > > > > > #include > > > +#include > > > > > > #ifdef __cplusplus > > > extern "C" { > > > @@ -35,8 +36,8 @@ > > > typedef khronos_int32_t GLfixed; > > > > > > /* GL types for handling large vertex buffer objects */ > > > -typedef khronos_intptr_t GLintptr; > > > -typedef khronos_ssize_t GLsizeiptr; > > > +typedef ptrdiff_t GLintptr; > > > +typedef ptrdiff_t GLsizeiptr; > > > > > > /* OpenGL ES core versions */ > > > #define GL_ES_VERSION_2_0 1 > > > > > > > > > > > Regards, > -- > Carlos Jacobo Puga Medina > _______________________________________________ > freebsd-chromium@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-chromium > To unsubscribe, send any mail to "freebsd-chromium-unsubscribe@freebsd.or= g > " >