From owner-freebsd-current@FreeBSD.ORG  Thu Oct 31 04:04:06 2013
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id A6E877A4;
 Thu, 31 Oct 2013 04:04:06 +0000 (UTC)
 (envelope-from sgk@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu
 [128.95.76.21])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 647EF2C97;
 Thu, 31 Oct 2013 04:04:06 +0000 (UTC)
Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu
 [127.0.0.1])
 by troutmask.apl.washington.edu (8.14.7/8.14.7) with ESMTP id r9V3hVrn057316; 
 Wed, 30 Oct 2013 20:43:31 -0700 (PDT)
 (envelope-from sgk@troutmask.apl.washington.edu)
Received: (from sgk@localhost)
 by troutmask.apl.washington.edu (8.14.7/8.14.7/Submit) id r9V3hVot057315;
 Wed, 30 Oct 2013 20:43:31 -0700 (PDT) (envelope-from sgk)
Date: Wed, 30 Oct 2013 20:43:31 -0700
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Eitan Adler <lists@eitanadler.com>
Subject: Re: [PATCH] Adjust binutils to quiesce -Wstring-plus-int
Message-ID: <20131031034331.GA57300@troutmask.apl.washington.edu>
References: <1383180558.1751.12.camel@localhost>
 <CAF6rxgns-Cvj+iNJvxNx5xVukAhj2jDd4OQvCSEiiqcuX_oscQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAF6rxgns-Cvj+iNJvxNx5xVukAhj2jDd4OQvCSEiiqcuX_oscQ@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: "freebsd-current@freebsd.org" <freebsd-current@freebsd.org>
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Oct 2013 04:04:06 -0000

On Wed, Oct 30, 2013 at 11:40:40PM -0400, Eitan Adler wrote:
> On Wed, Oct 30, 2013 at 8:49 PM, Sean Bruno <sean_bruno@yahoo.com> wrote:
> > Spent some time doing string maths today.
> >
> > More or less, change the "static char intel_syntax" to an int and use it
> > as an array index instead of doing pointer math.
> >
> > Sean
> >
> > http://people.freebsd.org/~sbruno/binutils_opcodes.txt
> 
> While the patch seems reasonable, I once again am confused about why
> we are fixing these warnings and not just disabling them for
> contributed code.

+1

-- 
Steve