From owner-svn-ports-head@freebsd.org  Tue Aug 21 19:34:50 2018
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1D2A6107D848;
 Tue, 21 Aug 2018 19:34:50 +0000 (UTC) (envelope-from pi@freebsd.org)
Received: from fc.opsec.eu (fc.opsec.eu [IPv6:2001:14f8:200:4::4])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id A1EE793AA5;
 Tue, 21 Aug 2018 19:34:49 +0000 (UTC) (envelope-from pi@freebsd.org)
Received: from pi by fc.opsec.eu with local (Exim 4.91 (FreeBSD))
 (envelope-from <pi@freebsd.org>)
 id 1fsCQM-0008sY-Ru; Tue, 21 Aug 2018 21:34:42 +0200
Date: Tue, 21 Aug 2018 21:34:42 +0200
From: Kurt Jaeger <pi@freebsd.org>
To: Yuri <yuri@rawbw.com>
Cc: Kurt Jaeger <pi@freebsd.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r477695 - in head/graphics: . libheif
Message-ID: <20180821193442.GN1673@fc.opsec.eu>
References: <201808210024.w7L0OIQH031059@repo.freebsd.org>
 <b4a250d0-7fe5-5830-d1d0-d93f3736471f@rawbw.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b4a250d0-7fe5-5830-d1d0-d93f3736471f@rawbw.com>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Aug 2018 19:34:50 -0000

Hi!

> On 8/20/18 5:24 PM, Kurt Jaeger wrote:
> > +BROKEN_FreeBSD_10=	encoder_fuzzer.cc:84:5: error: use of undeclared identifier 'free'
> 
> This is most likely wrong. 'free' is available everywhere. The likely 
> reason is a missing #include <stdlib.h> somewhere.

Yes, it was wrong. Thanks for the pointer, fixed.

> > +LIB_DEPENDS=		libde265.so:multimedia/libde265
> > +LIB_DEPENDS+=		libx265.so:multimedia/x265
> > +LIB_DEPENDS+=		libpng16.so:graphics/png

> These are usually defined without repeating LIB_DEPENDS+=.

Fixed.

> > +USES=			autoreconf libtool pkgconfig shared-mime-info \
> > +			shebangfix
> > +USE_GITHUB=		yes
> > +GH_ACCOUNT=		strukturag
> > +GH_PROJECT=		libheif
> > +
> > +GNU_CONFIGURE=		yes
> > +
> > +SHEBANG_GLOB=		*.sh
> > +
> > +USE_LDCONFIG=		yes
> 
> USE_LDCONFIG should definitely be in the USExx section. GNU_CONFIGURE and SHEBANG_GLOB should also probably be in USExx section, because this way Makefile looks more compact.

Done as you described.

-- 
pi@FreeBSD.org         +49 171 3101372              2 years to go !