From owner-svn-src-head@freebsd.org Sat Aug 24 15:49:55 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8FF70C3059; Sat, 24 Aug 2019 15:49:55 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46G2lR33dzz3MH5; Sat, 24 Aug 2019 15:49:55 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io1-f47.google.com with SMTP id z3so27286372iog.0; Sat, 24 Aug 2019 08:49:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=gmg/nTQ5GrmqYIumAX4MvQzmqy52LKIF2gYgIeuPnII=; b=InJIhVsp2q7Uug+pDfiOpOLNQmfdLMW+4TioJ/k4pv5ilF/DkTsqvq81wdkBYTaN0I 8d7hp+JpIize7Y/TGCVZ5fdBKwhGzW8mTKUeL4LRNzF2pQ2qtlcogxcnwZuJdgrRnMQk 9nIkp7YYB+uZfMAnLbQGHidxtBvJXkXy8IzcOdIw0dEsKr+bfQ+9h1N8RyECp4k4vbxn fbMlTdJjqtKNNtFO9iiteQhNo6SNuU+9LAHl3zC031uUCo49+PSC62GaD55EXQLM8vMf CoAPcL2Bs0G6gn4+EKjCZ0ZZlGe41+h4zsUYtduCeHSN7lV9C3j5Jm9HVmsScP0PnBt+ M/+g== X-Gm-Message-State: APjAAAW/YAzKXHStVbMAov7aKSGr+80A3q79ZmQrRk2dM2AEtAW4WexR 1yt6SqQlrm/dVZxR6kEKGHWzEAkz X-Google-Smtp-Source: APXvYqzSaa1PVWFtuRaUSFsqZK58eSmnBDyIX+30xF2+sLTssMHXSKbVTrKSQuOrRVo38++/G74ZVw== X-Received: by 2002:a05:6638:3af:: with SMTP id z15mr10156907jap.39.1566661793913; Sat, 24 Aug 2019 08:49:53 -0700 (PDT) Received: from mail-io1-f50.google.com (mail-io1-f50.google.com. [209.85.166.50]) by smtp.gmail.com with ESMTPSA id w6sm5040912iob.29.2019.08.24.08.49.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Aug 2019 08:49:53 -0700 (PDT) Received: by mail-io1-f50.google.com with SMTP id p12so27274111iog.5; Sat, 24 Aug 2019 08:49:53 -0700 (PDT) X-Received: by 2002:a6b:f216:: with SMTP id q22mr2637356ioh.65.1566661793111; Sat, 24 Aug 2019 08:49:53 -0700 (PDT) MIME-Version: 1.0 References: <201908241528.x7OFSemm026182@repo.freebsd.org> In-Reply-To: <201908241528.x7OFSemm026182@repo.freebsd.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Sat, 24 Aug 2019 08:49:42 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r351456 - head/sys/amd64/amd64 To: Konstantin Belousov Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46G2lR33dzz3MH5 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.977,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Aug 2019 15:49:55 -0000 Hi Konstantin, What is the motivation for this change? The commit message doesn't really describe why it was done. Thanks, Conrad On Sat, Aug 24, 2019 at 8:28 AM Konstantin Belousov wrote: > > Author: kib > Date: Sat Aug 24 15:28:40 2019 > New Revision: 351456 > URL: https://svnweb.freebsd.org/changeset/base/351456 > > Log: > Do not constrain allocations for doublefault, boot, and mce stacks. > > All these stacks are used only once (doublefault, boot) or very rare > (mce). > > Reviewed by: markj > Tested by: pho > Sponsored by: The FreeBSD Foundation > Differential revision: https://reviews.freebsd.org/D21320 > > Modified: > head/sys/amd64/amd64/mp_machdep.c > > Modified: head/sys/amd64/amd64/mp_machdep.c > ============================================================================== > --- head/sys/amd64/amd64/mp_machdep.c Sat Aug 24 15:25:53 2019 (r351455) > +++ head/sys/amd64/amd64/mp_machdep.c Sat Aug 24 15:28:40 2019 (r351456) > @@ -475,13 +475,11 @@ native_start_all_aps(void) > domain = acpi_pxm_get_cpu_locality(apic_id); > #endif > /* allocate and set up an idle stack data page */ > - bootstacks[cpu] = (void *)kmem_malloc_domainset( > - DOMAINSET_FIXED(domain), kstack_pages * PAGE_SIZE, > + bootstacks[cpu] = (void *)kmem_malloc(kstack_pages * PAGE_SIZE, > M_WAITOK | M_ZERO); > - doublefault_stack = (char *)kmem_malloc_domainset( > - DOMAINSET_FIXED(domain), PAGE_SIZE, M_WAITOK | M_ZERO); > - mce_stack = (char *)kmem_malloc_domainset( > - DOMAINSET_FIXED(domain), PAGE_SIZE, M_WAITOK | M_ZERO); > + doublefault_stack = (char *)kmem_malloc(PAGE_SIZE, M_WAITOK | > + M_ZERO); > + mce_stack = (char *)kmem_malloc(PAGE_SIZE, M_WAITOK | M_ZERO); > nmi_stack = (char *)kmem_malloc_domainset( > DOMAINSET_FIXED(domain), PAGE_SIZE, M_WAITOK | M_ZERO); > dbg_stack = (char *)kmem_malloc_domainset( >