From owner-freebsd-stable@FreeBSD.ORG Mon Feb 21 20:47:45 2011 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 50471106566B; Mon, 21 Feb 2011 20:47:45 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 860BF8FC08; Mon, 21 Feb 2011 20:47:44 +0000 (UTC) Received: by wwf26 with SMTP id 26so6344410wwf.31 for ; Mon, 21 Feb 2011 12:47:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=qwCWNv2u6GFAi+yrq8S6P6hewG8lm4IChW9Ap1HYWpI=; b=rk9bhQpSol9yQ/nl1UmSpwk2L8FdfsXmiTwmoOTTpWkw4lcuufBFBnIj0lmhZGUT9s 0NAeFbwwlVn2in6KGQxSJm7nfSXuTzrG5vHDIsMflMoX81Bn3PMdqkmyoXng/Ptef4Ua rQRYndf8h8yPbN1lcYA6xpDMhdvvRT7Ts5om0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=QjnKpLTewkiQS7/kPHsTxZsid/1IJJGZkrhIMOhF2koNmdchC0Yjit1Mh2JcJ2LLWK zHmndGM0QQ14wW+EWet5jCFTsqPua/nhsLdD+4+FCBW9MT/Rk+P6PyNtMfT37NhcBeCL /xzN8parYym0e5n4DPnltqqqyrLYonq9+Zwco= MIME-Version: 1.0 Received: by 10.216.241.138 with SMTP id g10mr1628225wer.27.1298321244744; Mon, 21 Feb 2011 12:47:24 -0800 (PST) Sender: yanegomi@gmail.com Received: by 10.216.71.200 with HTTP; Mon, 21 Feb 2011 12:47:24 -0800 (PST) In-Reply-To: <7048D14F1FD341F2AFD2B0CB13C95477@multiplay.co.uk> References: <8332E9240ECA403480B48D21FA3A8694@multiplay.co.uk> <4D6292DD.8010704@freebsd.org> <7048D14F1FD341F2AFD2B0CB13C95477@multiplay.co.uk> Date: Mon, 21 Feb 2011 12:47:24 -0800 X-Google-Sender-Auth: pJ654n1YnpnqwiaIHKihBV0HfY4 Message-ID: From: Garrett Cooper To: Steven Hartland Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-hackers@freebsd.org, freebsd-stable@freebsd.org, Andriy Gapon Subject: Re: machdep.hlt_cpus not safe with ULE? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Feb 2011 20:47:45 -0000 On Mon, Feb 21, 2011 at 12:30 PM, Steven Hartland wrote: > ----- Original Message ----- From: "Garrett Cooper" >> >> =A0 As a followup to this and based on discussions with other folks, >> the fact that it's using hlt to halt CPUs without rescheduling tasks / >> masking interrupts, etc is not good. So none of the *hlt* sysctls are >> really doing the right thing on x86. > > Time to disable them until they are fixed properly then I would suggest? Andriy's patch attached to the PR above does the right thing when first bringing up the system, but it's still broken with the sysctl case, so I would actually vote to disable the sysctls for now and commit his patch separately as it's better than the existing code is in that area. Thanks! -Garrett