From owner-svn-src-all@FreeBSD.ORG Thu Jun 9 17:25:20 2011 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 87F551065670; Thu, 9 Jun 2011 17:25:20 +0000 (UTC) (envelope-from gibbs@FreeBSD.org) Received: from aslan.scsiguy.com (ns1.scsiguy.com [70.89.174.89]) by mx1.freebsd.org (Postfix) with ESMTP id 527FA8FC08; Thu, 9 Jun 2011 17:25:20 +0000 (UTC) Received: from Justins-MacBook-Pro.local (207-225-98-3.dia.static.qwest.net [207.225.98.3]) (authenticated bits=0) by aslan.scsiguy.com (8.14.4/8.14.4) with ESMTP id p59HPKj9054209 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 9 Jun 2011 11:25:20 -0600 (MDT) (envelope-from gibbs@FreeBSD.org) Message-ID: <4DF101F9.4020600@FreeBSD.org> Date: Thu, 09 Jun 2011 11:25:13 -0600 From: "Justin T. Gibbs" Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10 MIME-Version: 1.0 To: "Andrey V. Elsukov" References: <201105031854.p43IsIJ5006816@svn.freebsd.org> In-Reply-To: <201105031854.p43IsIJ5006816@svn.freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (aslan.scsiguy.com [70.89.174.89]); Thu, 09 Jun 2011 11:25:20 -0600 (MDT) Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r221397 - in head/sys: kern sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: gibbs@FreeBSD.org List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2011 17:25:20 -0000 On 5/3/11 12:54 PM, Andrey V. Elsukov wrote: > Author: ae > Date: Tue May 3 18:54:18 2011 > New Revision: 221397 > URL: http://svn.freebsd.org/changeset/base/221397 > > Log: > Add make_dev_alias_p() function. It is similar to make_dev_alias(), > but it may return an error like make_dev_p() does. Sorry for the late reply on this change. I noticed it during some recent merge activity at work where my make_dev_credv() conflicted with your make_dev_cred_v(). It seems that the existing convention in this file for "function variants" is to append a single letter to the function name without an underscore (e.g. make_dev_credv, make_dev_credf). make_dev_alias_v() and make_dev_p(), break this convention. It would be nice to clean up this API so that the naming conventions are consistent. So which should it be? Underscore or no underscore? -- Justin