Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 9 Mar 2023 11:00:13 -0600
From:      Kyle Evans <kevans@freebsd.org>
To:        Baptiste Daroussin <bapt@freebsd.org>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org,  dev-commits-src-main@freebsd.org
Subject:   Re: git: b2654064c2d1 - main - pkg(7): use libmd for sha256 instead of openssl
Message-ID:  <CACNAnaFdO9BGGfFA=xUJ31JRsJ_AbicRGHxeFjN3jXE6HQw_QA@mail.gmail.com>
In-Reply-To: <202303091643.329GhNWr046904@gitrepo.freebsd.org>
References:  <202303091643.329GhNWr046904@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 9, 2023 at 10:43=E2=80=AFAM Baptiste Daroussin <bapt@freebsd.or=
g> wrote:
>
> The branch main has been updated by bapt:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=3Db2654064c2d11a1ee36667b3ff=
8b0f4d2536af74
>
> commit b2654064c2d11a1ee36667b3ff8b0f4d2536af74
> Author:     Baptiste Daroussin <bapt@FreeBSD.org>
> AuthorDate: 2023-03-09 16:38:30 +0000
> Commit:     Baptiste Daroussin <bapt@FreeBSD.org>
> CommitDate: 2023-03-09 16:43:01 +0000
>
>     pkg(7): use libmd for sha256 instead of openssl
>
>     OpenSSL 3.0 has deprecated the sha256 api, let's use libmd which has =
the
>     same API instead.
>
>     In order to avoid the collision in definitions (sha256.h cannot be
>     included in the same file as a file where openssl headers has been
>     included) let's move the sha256 related code in its own file
>
>     PR:             270023
>     Reported by:    ngie
> ---

If we're going to link against libmd anyways, any reason to keep these
implementations vs using the provided SHA256_Data and SHA256_Fd?

Thanks,

Kyle Evans



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaFdO9BGGfFA=xUJ31JRsJ_AbicRGHxeFjN3jXE6HQw_QA>