From owner-freebsd-current Tue Aug 11 10:14:06 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id KAA04624 for freebsd-current-outgoing; Tue, 11 Aug 1998 10:14:06 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from zone.syracuse.NET (zone.syracuse.net [205.232.47.17]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id KAA04618 for ; Tue, 11 Aug 1998 10:14:04 -0700 (PDT) (envelope-from green@zone.syracuse.NET) Received: from localhost (green@localhost) by zone.syracuse.NET (8.8.8/8.8.7) with SMTP id NAA01664; Tue, 11 Aug 1998 13:12:06 -0400 (EDT) Date: Tue, 11 Aug 1998 13:12:06 -0400 (EDT) From: Brian Feldman To: Luoqi Chen cc: archer@lucky.net, bde@zeta.org.au, current@FreeBSD.ORG Subject: Re: New softupdates code panics In-Reply-To: <199808111412.KAA27035@lor.watermarkgroup.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG I think I understand here, you meant the association of the code would be (doingdirectory && newparent) ? newparent : doingdirectory rather that doingdirectory && (newparent ? newparent : doingdirectory) correct? And that would have been what led to the confusion. Cheers, Brian Feldman On Tue, 11 Aug 1998, Luoqi Chen wrote: > > >> The same here. My system paniced two times for some 4 hours after > > >> I've booted kernel with Kirk's patches. The system was not very > > >> busy, just ordinary mail/news reception (it is home computer). > > >> > > >Change the expression ``newparent ? newparent : doingdirectory'' in Kirk's > > >patch to ``doingdirectory && newparent ? newparent : doingdirectory''. > > >(for file ufs/ufs/ufs_vnops.c) > > > > Um, this expression is equivalent to ``doingdirectory'', which is the > > same as the unpatched expression. General fuzzy reasoning suggests that > > the expression should be ``doingdirectory && !newparent''. > > > > Bruce > > > newparent is not a boolean, and neither is the expression, they are integers. > The expression used to be boolean, but now we want it to have three states: > 0, 1, and >1, with the third state be doingdirectory && newparent. You could > write the expression as ``doingdirectory && newparent ? 2 : doingdirectory''. > > -lq > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-current" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message