Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 7 Apr 2018 20:00:58 +0000 (UTC)
From:      Michael Tuexen <tuexen@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r332216 - stable/11/sys/netinet
Message-ID:  <201804072000.w37K0whH074961@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: tuexen
Date: Sat Apr  7 20:00:58 2018
New Revision: 332216
URL: https://svnweb.freebsd.org/changeset/base/332216

Log:
  MFC r324954:
  
  Fix a locking issue found by running AFL on the userland stack.
  Thanks to Felix Weinrank for reporting the issue.

Modified:
  stable/11/sys/netinet/sctp_input.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/netinet/sctp_input.c
==============================================================================
--- stable/11/sys/netinet/sctp_input.c	Sat Apr  7 19:59:40 2018	(r332215)
+++ stable/11/sys/netinet/sctp_input.c	Sat Apr  7 20:00:58 2018	(r332216)
@@ -4866,9 +4866,6 @@ process_control_chunks:
 				if ((stcb != NULL) && (stcb->asoc.total_output_queue_size)) {
 					;
 				} else {
-					if (stcb != NULL) {
-						SCTP_TCB_UNLOCK(stcb);
-					}
 					*offset = length;
 					if (stcb != NULL) {
 #if defined(__APPLE__) || defined(SCTP_SO_LOCK_TESTING)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201804072000.w37K0whH074961>