Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 15 Jan 2003 16:29:50 -0800 (PST)
From:      David Xu <davidxu@FreeBSD.org>
To:        Nate Lawson <nate@root.org>
Cc:        "cvs-all@FreeBSD.org" <cvs-all@FreeBSD.org>, cvs-committers@FreeBSD.org
Subject:   Re: cvs commit: src/sys/kern subr_bus.c
Message-ID:  <200301160029.h0G0To0o099625@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

----- Original Message ----- 
From: "Nate Lawson" <nate@root.org>
To: "David Xu" <davidxu@FreeBSD.org>
Cc: <cvs-all@FreeBSD.org>; <cvs-committers@FreeBSD.org>
Sent: Thursday, January 16, 2003 2:16 AM
Subject: Re: cvs commit: src/sys/kern subr_bus.c


> On Wed, 15 Jan 2003, David Xu wrote:
> >   Modified files:
> >     sys/kern             subr_bus.c 
> >   Log:
> >   Don't forget to disconnect object from class.
> >   
> >   Revision  Changes    Path
> >   1.121     +3 -2      src/sys/kern/subr_bus.c
> 
> Does this fix the memory leak when loading/unloading a module many
> times?  I've seen indications that there was one but haven't tracked it
> down farther.
> 
> -Nate

In device_delete_child, this fixed nullclass reference count.
because the class is always in memory and already compiled,
there is no memory leak. 
 
Only in device_set_driver, if system is out of memory, it would
cause memory leak. but at that time, I don't think the system will
continue running, it would panic in other places.
So these are nits.

David


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200301160029.h0G0To0o099625>