From owner-svn-src-head@FreeBSD.ORG Sat Nov 1 10:47:19 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3A36CAE3; Sat, 1 Nov 2014 10:47:19 +0000 (UTC) Received: from mail-wg0-x231.google.com (mail-wg0-x231.google.com [IPv6:2a00:1450:400c:c00::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 36E4C7C6; Sat, 1 Nov 2014 10:47:18 +0000 (UTC) Received: by mail-wg0-f49.google.com with SMTP id x13so9395032wgg.8 for ; Sat, 01 Nov 2014 03:47:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=pp1CEaeEw664mEeIafBfq59Vpt/rr3fS1rCOIocKIPc=; b=vCRACRnaX5SSSmJxg3PUqYXGgcLuNOGDuXtt4qaZCNDngl3C2mecNrPikMUOmA2wn5 xG7Is/8eKrloMtD9zDZElWgMyb8lwnqfvlyzu52wVItft6lDw31VMS+WxOo4OTk16fs9 V8aW2NGeE//NyRcBE7CXPYCskR676t0w79IV1Yj9TQJtobAyL0lq9UdUxfAAZtG+0te7 izp1bem7UU5u6lrvsCG1P/0MXDrDGrw76CODCQLgCXPH5XGWEqcYpHo8NAZ+iFW49MF3 i6abuHGfdVPhD35ZVnxVj9JZJCMpnQYR+j4LQVQLtsoL8qHDS5P8x08PY/fzvTtAEBRc XLSg== MIME-Version: 1.0 X-Received: by 10.195.12.76 with SMTP id eo12mr34472393wjd.22.1414838836369; Sat, 01 Nov 2014 03:47:16 -0700 (PDT) Received: by 10.216.204.71 with HTTP; Sat, 1 Nov 2014 03:47:16 -0700 (PDT) In-Reply-To: References: <201410311915.s9VJFEDZ003525@svn.freebsd.org> Date: Sat, 1 Nov 2014 08:47:16 -0200 Message-ID: Subject: Re: svn commit: r273917 - head/sys/dev/gpio From: Luiz Otavio O Souza To: "Bjoern A. Zeeb" Content-Type: text/plain; charset=UTF-8 Cc: Luiz Otavio O Souza , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Nov 2014 10:47:19 -0000 On Sat, Nov 1, 2014 at 7:56 AM, Bjoern A. Zeeb wrote: > > On 31 Oct 2014, at 19:15 , Luiz Otavio O Souza wrote: > >> Author: loos >> Date: Fri Oct 31 19:15:14 2014 >> New Revision: 273917 >> URL: https://svnweb.freebsd.org/changeset/base/273917 >> >> Log: >> Fix the gpiobus locking by using a more sane model where it isn't necessary >> hold the gpiobus lock between the gpio calls. >> >> gpiobus_acquire_lock() now accepts a third parameter which tells gpiobus >> what to do when the bus is already busy. >> >> When GPIOBUS_WAIT wait is used, the calling thread will be put to sleep >> until the bus became free. >> >> With GPIOBUS_DONTWAIT the calling thread will receive EWOULDBLOCK right >> away and then it can act upon. >> >> This fixes the gpioiic(4) locking issues that arises when doing multiple >> concurrent access on the bus. > > I guess it was this commit that broke things: > > /scratch/tmp/bz/head.svn/sys/dev/gpio/gpioled.c: In function 'gpioled_control': > /scratch/tmp/bz/head.svn/sys/dev/gpio/gpioled.c:88: error: 'GPIOBUS_DONTWAIT' undeclared (first use in this function) > /scratch/tmp/bz/head.svn/sys/dev/gpio/gpioled.c:88: error: (Each undeclared identifier is reported only once > /scratch/tmp/bz/head.svn/sys/dev/gpio/gpioled.c:88: error: for each function it appears in.) > --- gpioled.o --- > *** [gpioled.o] Error code 1 > > bmake: stopped in /storage/head/obj/mips.mips/scratch/tmp/bz/head.svn/sys/AP121 > --- buildkernel --- > *** [buildkernel] Error code 1 Fixed in r273926. Sorry for the breakage. Luiz