From owner-svn-src-head@freebsd.org Thu Jan 25 15:17:03 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C7EF7EB4B92 for ; Thu, 25 Jan 2018 15:17:03 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from sonic301-17.consmr.mail.bf2.yahoo.com (sonic301-17.consmr.mail.bf2.yahoo.com [74.6.129.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6A0A781579 for ; Thu, 25 Jan 2018 15:17:03 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1516893422; bh=A7msxxBQ2Pdp0CdENSufyNux3KTser5j51aAsjiYJAc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=PqptV+0KsmWFn86FVtQ2/INGTKPXifpXoQAWD0imC31qkdLU6QCh9ujdToeFu99rIxa4UHFT5ENiwKPXIUd97UbBGRwyVKat6Je+lwB6Af4ztF+kMJ8J8OFz4/PmUGC9sGrqdZ9llct/XAjg4J6og9xe0ZjSVQdQtwXH8rvluzFMixn5ZP6aHKociecPhxokz6cQuQ1pxc6CTmIrL/EVumLWKG42DrST6DfC5vFLeRkaIVVYX+XhkgNGUijayRE6tydaTbtB+u6InZFjvQNbFjTMrgf7T5OrGkZNqg/6Zo5rIPbxI8xzsX4BrDPi0xUzAp+GckFKnM9vXFPyBrV4HQ== X-YMail-OSG: Ghb060UVM1lnI8aWioYj9QqXSMifMLQzLKFlYdXgPy.CK05Odh328bZZ78PE1Yq ffK2zE_fv0QRWfj0.i93lVsuq87iubgSablgnYMo0AckV10yjr8QV0.D5iVw2iBjFZxeLD7Czn88 .4mJWO4mtWGj.zS6ptcn1ZmzXFCswGsavZui4NAf4eP.iijWSIKRdAWqoVAprKJcsp4GYvk5INeV 6szTkoZDwVpGkjBcwyYP6COCMCPyEWwthFOlJd6J9uE7nUVR6drLtjh23u4.d8FVR9IEZD8oT7AL rESG2uc02Eg1rCXXol8fNdoQs1YeerJCnZnoaAAXYzrC6DDCuoVC_LFr7gS7i4lTanFPpsrrPGmw c3KmpBWzwHP9RbGuPShflnahI4bx5_yRu2MCTQNyU_xkwpcI7n8qxSj83DvNsE0nkw.DaZGX2ZIK lDpqKwJk.re2kAccGxvOZ0VBGkf0m35pUR3coDWTG58dcLiqo4qjWJhbN8H7ILVjN7gX3Q5ofa4M bl4z31Q9Ruw-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.bf2.yahoo.com with HTTP; Thu, 25 Jan 2018 15:17:02 +0000 Received: from smtpgate102.mail.bf1.yahoo.com (EHLO [192.168.0.8]) ([72.30.28.113]) by smtp401.mail.bf1.yahoo.com (JAMES SMTP Server ) with ESMTPA ID 40b9a20514444a8784246301e1b57aff; Thu, 25 Jan 2018 15:06:52 +0000 (UTC) Subject: Re: svn commit: r328340 - in head/sys: fs/ext2fs ufs/ffs ufs/ufs To: Bruce Evans Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201801241644.w0OGivto028334@repo.freebsd.org> <20180126010213.X1950@besplex.bde.org> From: Pedro Giffuni Organization: FreeBSD Project Message-ID: <71173c5c-4f3f-2228-7157-2d657ae46eea@FreeBSD.org> Date: Thu, 25 Jan 2018 10:06:52 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180126010213.X1950@besplex.bde.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 15:17:03 -0000 On 25/01/2018 09:42, Bruce Evans wrote: > On Wed, 24 Jan 2018, Pedro F. Giffuni wrote: > >> Log: >>  Revert r327781,  r328093, r328056: >>  ufs|ext2fs: Revert uses of mallocarray(9). >> >>  These aren't really useful: drop them. >>  Variable unsigning will be brought again later. > > Variable "unsigning" (that is, adding unsign extension bugs) is even more > negatively useful than mallocarray(), so should not be brought back. > Any specific case? I already brought those back in r328346. > Unsigning variables used _only_ for array sizes and element counts > doesn't > cause any new problems (and fixes warnings about converting from > signed to > unsigned when calling malloc*()), but it is a lot of work to check that > they aren't used for other things where their signedness matters (perhaps > differences or loops that count down to -1 instead of 0). > I did check and had mckusick crosscheck before, but as you say it is usually a lot of work and my have missed something. Pedro.